kit: undici's `new Request` is incompatible with HTTP/2 requests
Describe the bug
After migration to SvelteKit 2 serving throw https just stopped working. It does not crash on execution but at the moment we reach exposed endpoint it returns the following error:
TypeError: Headers.append: ":method" is an invalid header name.
at webidl.errors.exception (node:internal/deps/undici/undici:1635:14)
at webidl.errors.invalidArgument (node:internal/deps/undici/undici:1646:28)
at appendHeader (node:internal/deps/undici/undici:2052:29)
at fill (node:internal/deps/undici/undici:2038:11)
at new Request (node:internal/deps/undici/undici:6151:13)
at getRequest (file:///Users/gfbatista/Projects/skedmill_ts/frontend/node_modules/@sveltejs/kit/src/exports/node/index.js:101:9)
at file:///Users/gfbatista/Projects/skedmill_ts/frontend/node_modules/@sveltejs/kit/src/exports/vite/dev/index.js:475:27
Reproduction
This error can be reproduced by starting a new SvelteKit 2 project and changing vite.config.ts accordingly with documentation provided here: https://vitejs.dev/guide/migration#remove-https-flag-and-https-true . I have tried to use https://github.com/vitejs/vite-plugin-basic-ssl and https://github.com/liuweiGL/vite-plugin-mkcert both with same result. vite.config.ts file:
import { sveltekit } from '@sveltejs/kit/vite';
import basicSsl from '@vitejs/plugin-basic-ssl'
import { defineConfig } from 'vite';
export default defineConfig({
plugins: [basicSsl(), sveltekit()]
});
### Logs
```Shell
TypeError: Headers.append: ":method" is an invalid header name.
at webidl.errors.exception (node:internal/deps/undici/undici:1635:14)
at webidl.errors.invalidArgument (node:internal/deps/undici/undici:1646:28)
at appendHeader (node:internal/deps/undici/undici:2052:29)
at fill (node:internal/deps/undici/undici:2038:11)
at new Request (node:internal/deps/undici/undici:6151:13)
at getRequest (file:///.../node_modules/@sveltejs/kit/src/exports/node/index.js:101:9)
at file:///.../node_modules/@sveltejs/kit/src/exports/vite/dev/index.js:475:27
### System Info
```Shell
System:
OS: macOS 14.2
CPU: (8) arm64 Apple M1 Pro
Memory: 130.47 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 21.4.0 - ~/.nvm/versions/node/v21.4.0/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v18.12.1/bin/yarn
npm: 10.2.4 - ~/.nvm/versions/node/v21.4.0/bin/npm
pnpm: 7.27.0 - ~/.nvm/versions/node/v18.12.1/bin/pnpm
bun: 1.0.13 - ~/.bun/bin/bun
Browsers:
Safari: 17.2
npmPackages:
@sveltejs/adapter-auto: ^3.0.0 => 3.0.0
@sveltejs/kit: ^2.0.0 => 2.0.0
@sveltejs/vite-plugin-svelte: ^3.0.0 => 3.0.1
svelte: ^4.2.7 => 4.2.8
vite: ^5.0.0 => 5.0.10
Severity
serious, but I can work around it
Additional Information
I think that should be a resurgence of this issue: https://github.com/sveltejs/kit/issues/3479 I have tryed this work around and it works:
vite.config.ts:
import basicSsl from '@vitejs/plugin-basic-ssl'
import { defineConfig } from 'vite';
export default defineConfig({
server: {
proxy: {}
},
plugins: [basicSsl(), sveltekit()]
});```
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 19
- Comments: 18 (5 by maintainers)
Downgrading to node 20 worked initially, but then it would crash with a “Transfer-Encoding” header being present.
Adding
server.proxy: {}worked:@kamerat I see the same. The error occurs when upgrading from Node v20.12.0 to v20.12.1. The
server.proxy: {}setting did not work for me.Here’s the changelog. Based on the stracktrace above, the error is being thrown in the undici library, which seems to have been updated from v5.28.3 to v5.28.4 in Node v20.12.1, but I’m having trouble seeing what specifically should have changed between these versions to cause this error.
Interestingly, it seems that there was an attempt at fixing this a long time ago in Sveltekit which was then reverted back again: https://github.com/sveltejs/kit/pull/7142
Update 2024-05-02
This is also an issue on Node 22.1.0
@bogacg yes proxy worked for me too!
I just upgraded a project to SvelteKit 2 (2.7.1), and I believe I’m experiencing a similar issue with a different error log. I’m using vite-plugin-mkcert@1.17.6 to enable the https server.
I was using node v20.18.0. Downgrading to v20.11.0 as suggested above was also a functional workaround for me.
@mattpilott I also did get that error again (I guess it was last week or early this week) and then updated my packages, clean install and run it in Node 21 latest this time. Added
proxy: {}option to config as @liamdiprose advised. I’ve been running error free this week.I’ve just run into this after updating to 20.12.1
Log
A simple downgrade from v20.12.1 back to v20.11.0, without any other config file change, worked here.
I tested different recent node versions to see where it broke and it seems v20.12.1 is where this error occurs for me.
Yeah, I think I’m coming to the same conclusion that undici’s
Requestisn’t a great fit for our usecase. The HTTP/2 pseudo headers like:methodare set in the fetch request by the browser. You can’t do something likenew Request('/', { headers: { ':method': 'POST' }});in the browser and so I understand why undici rejects those for compatibilitySo I think we have two options here:
:methodtomethodand:authoritytohostand then drop:schemeand:path. It’s not quite representative of what the server is actually receiving, but in some ways it makes things easier for the user and framework as you could just check formethodvs checkingmethodand:method. We’d have to make this change in each adapterRequestimplementation whether by forkingundici, writing our own, etc.Option 2 sounds far harder to implement, so I would lean towards option 1
I generated my certs with
mkcertand load them manually.the helper function i came up.
for a work round…