aggligator: Doesn't build on FreeBSD

See here:

https://github.com/ikatson/rqbit/pull/53/files

There’s an issue with network-interface that causes it to not build on BSD. Unfortunately, it works into further issues using the fork they use, because we end up with this:


   --> aggligator-util/src/transport/tcp.rs:485:21
    |
485 |                 let Some(addr) = ifn.addr else { continue };
    |                     ^^^^^^^^^^   -------- this expression has type `Vec<Addr>`
    |                     |
    |                     expected `Vec<Addr>`, found `Option<_>`
    |
    = note: expected struct `Vec<Addr>`
                 found enum `Option<_>`

About this issue

Original URL
State: closed
Created 5 months ago
Comments: 16 (5 by maintainers)

Most upvoted comments

Regarding the speed issues, I can confirm that they are not issues. Using bare metal hardware, speed is as good as linux.

cmspam on Mar 31, 2024

Strange, my rates are much higher. What VM hypervisor are you using? I use KVM with virt-manager GUI.

I am using KVM/qemu also, but managed with incus. But the hardware is not powerful. It’s just celeron N5100. Still, it is enough for a Linux VM to show good performance, and for other software in FreeBSD to show higher network performance with curl/iperf/other network utilities, so it’s kind of a mystery to me.

Still, I have seen cases where FreeBSD network performance is horrible, until it is run on bare metal due to issues with hardware offloading on virtio, and I wouldn’t rule that out as the cause, so I really need to get around to trying it on other machines and/or bare metal soon to see if there is a big difference.

cmspam on Mar 27, 2024

It’s been a while. I just want to give you a HUGE thank you. Aggligator is life-changing for my use case. I’ve had to depend on mptcp, which means always running linux VMs or linux, always making sure that mptcp is supported, doing various workarounds…

I’ve just done a bit of testing (albeit linux-based) for all of the workloads that I use MPTCP for, and aggligator actually is on par with or even outperforms the previous mptcp implementations in many cases!

I also want to thank you for your PR to get FreeBSD working with network-interface.

I will continue to experiment with aggligator over the upcoming days, particularly with BSD.

Again, a huge thanks.

cmspam on Mar 25, 2024