super-linter: Why does Versioning not work?
Describe the bug There is a bug in v3.10.0 so I have not upgraded to this version so am still running 3.9.4.
I still hit the bug.
To Reproduce Steps to reproduce the behavior:
- Setup an action with node_modules and lock the version:
uses: github/super-linter@v3.9.4 - Lint a repo with a
node_modulesfolder. Note this folder gets linted when it previously didn’t
Expected behavior Versions should lock the code for stability. It’s pointless using version numbers if they are ignored and latest is always run.
Screenshots Example run: https://github.com/HTTPArchive/almanac.httparchive.org/pull/1062/checks?check_run_id=1095951259 As can be seen it’s running v3.9.4 but is showing the bug from 3.10.0
Additional context This has been going on a while but annoyed me enough to raise a separate issue for this.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 2
- Comments: 24 (16 by maintainers)
Keep open please, unless explicitly planning not to support this, as I’d still like to explicitly lock the version and only upgrade when dependabot notifies me and gives me the choice. Especially given a few broken releases like those mentioned above.
@dec5e Hey! I agree… it has been hard to get some time on this issue but I will try to find some internal help at GitHub from the Actions team and see if there is something better we can be doing.
Sorry for the outages that have been caused, we’re working on more testing and better vetting of the source.
I see we’ve released another bug in #938 breaking all linting on anyone using this project. Can we please look at this issue and introduce proper versioning to avoid this?