storybook: Theme variables(brandTitle, brandUrl, brandImage) not working

Describe the bug Even if I set brandTitle, brandUrl, brandImage on theme object, It doesn’t work at all(5.1.0-alpha.27)

To Reproduce Set any combinations of brandTitle, brandUrl, brandImage of defined, undefined, null on theme object.

Expected behavior SidebarHeading should be rendered according to the inputs from options

System:

  • OS: Windows10, Ubuntu 18.04
  • Browser: chrome, firefox
  • Framework: react
  • Version: 5.1.0-alpha.27

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Reactions: 2
  • Comments: 22 (20 by maintainers)

Most upvoted comments

It is this line

https://github.com/storybooks/storybook/blob/8c4ee76dab03402b6d5a89b08a2504939d6f23e4/lib/theming/src/create.ts#L175

this prevents the user from setting a brandImage

+1
hipstersmoothie on Apr 17, 2019

@lonyele 화이팅! ㅋㅋㅋㅋ

+1
shilman on Apr 16, 2019
Read more comments on GitHub
← storybook: Theme variable brandTitle incorrectly applied
storybook: TS1086: An accessor cannot be declared in an ambient context →