storybook: Breaking changes in @storybook/polymer from 5.1.3 to 5.1.4
Describe the bug Upgrade @storybook/polymer from 5.1.3 to 5.1.4 breaks storybook.
ERROR in [PROJECT_PATH]/node_modules/@storybook/core/dist/server/common/polyfills.js
Module not found: Error: Cannot find module '[PROJECT_PATH]/node_modules/@open-wc/demoing-storybook/node_modules/@storybook/addon-storysource/loader.js![PROJECT_PATH]/node_modules/core-js/features/symbol/index.js'
Require stack:
- [PROJECT_PATH]/node_modules/@storybook/core/dist/server/preview/noop.js
@ [PROJECT_PATH]/node_modules/@storybook/core/dist/server/common/polyfills.js 7:0-34
@ multi [PROJECT_PATH]/node_modules/@storybook/core/dist/server/common/polyfills.js [PROJECT_PATH]/node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js (webpack)-hot-middleware/client.js?reload=true
and some 4 more similar errors.
To Reproduce Steps to reproduce the behavior:
- Update to 5.14
- Run
start-storybook -s .
- See error
Expected behavior Build the storybook project
Screenshots If applicable, add screenshots to help explain your problem.
Code snippets
System:
- OS: MacOS
- Device: Macbook Pro 2018
- Browser: -
- Framework: Polymer (WebComponents - LitElement)
- Addons: -
- Version: 5.1.4
Additional context Add any other context about the problem here.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 5
- Comments: 20 (17 by maintainers)
I was finally able to get 5.1.11 to build, using the following
webpack.config.js
:If someone wants that commit be make it into @storybook/polymer, they’d have to open a PR here https://github.com/storybookjs/storybook/tree/master/app/polymer
FYI we’re dropping support for storybook for polymer and focussing on supporting plain web-components instead.