standard: standard v14 not working with files in a different directory

What version of this package are you using? 14.0.0 What operating system, Node.js, and npm version? Void Linux, node 10.16.3, npm 6.9.0 What happened? $ standard --fix $file-not-same-directory fails with

/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/node_modules/ignore/index.js:337
  throw new Ctor(message)
  ^

RangeError: path should be a `path.relative()`d string, but got "../../tmp/crap.js"
    at throwError (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/node_modules/ignore/index.js:337:9)
    at checkPath (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/node_modules/ignore/index.js:356:12)
    at Ignore._test (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/node_modules/ignore/index.js:473:5)
    at Ignore.ignores (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/node_modules/ignore/index.js:512:17)
    at path (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/node_modules/ignore/index.js:516:26)
    at Array.filter (<anonymous>)
    at Ignore.filter (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/node_modules/ignore/index.js:520:29)
    at /home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/deglob/index.js:46:31
    at end (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/run-parallel/index.js:18:15)
    at done (/home/pedro/.nvm/versions/node/v10.16.3/lib/node_modules/standard/node_modules/run-parallel/index.js:22:10)

but $ standard --fix file.js works as expected

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 2
Comments: 17 (6 by maintainers)

Links to this issue

chore(deps): update dependency standard to v17 (!31) · Merge requests · GitLab.org / security-products / Package Hunter CLI · GitLab

Commits related to this issue

Fix 2816 - Standard fix does not work. The standard linter --fix fails if the file being input is not relative to the project root (https://github.com/standard/standard/issues/1384). This MR attempt... — committed to hsanson/ale by deleted user 4 years ago

Most upvoted comments

I can no longer reproduce this issue, so perhaps it was fixed upstream in ignore? In either case, we’re removing deglob (which was invoking ignore) in the next version of standard, v16.

So, this issue should be fixed!

feross on Oct 29, 2020