standard: Don't iterate over files and folders that should be ignored
In a project of mine, I have a build directory that quickly gets really large. It’s ignored via .gitignore, so standard doesn’t fail on it, but it still runs through all files in the directory. It results in a running time of 13 seconds as opposed to 1 second without the build directory.
I know this have been discussed before (#680) and it seems to be a “feature” inherited from eslint. But I’m opening this issue to hopefully start a discussion on how to work around this or how to potentially fix it (either in standard or in eslint).
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 1
- Comments: 19 (14 by maintainers)
I’m removing
deglobforstandard16. So this issue will be fixed for free!I took at stab at this and found that this is a combination of a few issues.
As @searls pointed out, the issue is inside deglob.
ignoreoption passed to the glob module does not contain patterns found in the.gitignorefile, so files only ignored here will still be processed by glob.gitignorefile were passed to theignoreoption, these would have to end with/**to ignore whole directories. This is inconsistent with how.gitignoreworks and with what’s documented in the READMESuggested solution:
/**to directories you wish to ignore in the package.jsonstandard.ignorearray.gitignoreto patterns compatible with the glob module and add them to the list of ignored glob patterns@feross what do you think of this?
LOL amazing issue report
@ematipico Correct. I think what @Flet was hinting at was if the solution to this might come automatically when at some point standard is upgraded to 4.x