stampit: Can't override normal function with generator function with `methods`

I changed the hook definition from #223 and implemented is a noop function:

let DefaultHooks = stampit().methods({
  preHook:() => {}
});

so I can override it with an implementation if needed in other stamps like:

let LoggerHooks = stampit().compose(DefaultHooks).methods({
  preHook:function *() {
    yield console.log(arg);
  }
});

This works only for normal functions and not for generator functions. My current workarround is

let LoggerHooks = stampit().compose(DefaultHooks).init(function ({instance}) {
  instance.preHook = function *() {
    yield console.log(arg);
  };
});

@koresar I took a short try with current v3rc but it breaks my code base too hard. Perhaps this is already fixed in v3?

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 18 (13 by maintainers)

Most upvoted comments

Lodash v4 does consider generators as functions, so it’s merely problem of v3, so it’s not necessary to report that.

I’ve merged pull request, lodash does too sofisticated checks for our needs.

danielkcz on Jul 29, 2016

Okay, so stampit is using lodash/isFunction to check values. Lodash is not using typeof value === 'function'. Instead, it is using value.toString() === '[object Function]'.

> var g = function* (){};
> Object.prototype.toString.call(g);
'[object GeneratorFunction]'

> var f = function (){};
> Object.prototype.toString.call(f);
'[object Function]'

I believe stampit v2 need a fix to allow generators, as well as stampit v3. Right?

To fix stampit v2 we need to patch the supermixer module. Any volunteers?

I’ll fix stampit v3.

koresar on Jul 29, 2016

v3 is stable. Not released though. 😃 Working on it as we speak.

koresar on Jul 27, 2016