Reloader: [BUG] Deployment.apps "reloader-reloader" is invalid: spec.template.metadata.labels
Describe the bug Unable to deploy reloader using the official helm chart.
To Reproduce Checkout the master branch and run
helm -n reloader upgrade --install reloader ./charts/reloader -f ./values.yml
Error: UPGRADE FAILED: failed to create resource: Deployment.apps "reloader-reloader" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"app.kubernetes.io/instance":"reloader", "app.kubernetes.io/managed-by":"Helm", "app.kubernetes.io/name":"reloader", "app.kubernetes.io/version":"v1.3.0", "group":"com.stakater.platform", "helm.sh/chart":"reloader-2.0.0", "provider":"stakater", "version":"v1.3.0"}: `selector` does not match template `labels`
Expected behavior Should have deployed without errors.
Solution might be to use reloader-fullname for the labels: https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/templates/_helpers.tpl#L31 or use reloader-name in https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/templates/deployment.yaml#L28.
Happy to make this a PR
Screenshots If applicable, add screenshots to help explain your problem.
Environment
- Operator Version:
- Kubernetes/OpenShift Version:
Additional context Add any other context about the problem here.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 20
- Comments: 18 (4 by maintainers)
Commits related to this issue
- Downgrade reloader to 2.0.0 to solve https://github.com/stakater/Reloader/issues/897 — committed to arch-anes/self-hosted-services by abelfodil 2 years ago
Downgrading to 2.0.0 solves the problem for now.
@MuneebAijaz Chart 2.1.0 is still giving me the same error.
Thanks for the fix, confirmed v2.1.2 installed and upgraded from (2.0.0) works
I have the same problem with 2.1.0
I have just released another version, can someone try now and let me know pls? It passed for me on local upgrade
Same here 😩 Flux just updated to the latest chart and I’m now getting:
* Deployment.apps "reloader-reloader" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"app.kubernetes.io/instance":"reloader", "app.kubernetes.io/managed-by":"Helm", "app.kubernetes.io/name":"reloader", "app.kubernetes.io/version":"v1.4.0", "group":"com.stakater.platform", "helm.sh/chart":"reloader-2.1.0", "provider":"stakater", "version":"v1.4.0"}: `selector` does not match template `labels`That won’t resolve an issue, since that is a major change. @gawbul Selector labels are immutable, hence, chart should be versioned as 3.0.0, but not 2.1.0. In order to fix an existing installation you have to delete the reloader deployment and Helm will be able to recreate it. Not a big deal, since reloader is stateless, but anyway…
@karl-johan-grahn @rasheedamir This bug is preventing proper upgrade to 1.4.1