dnscontrol: ORACLE: inconsistent behavior for "trailing dot on nameserver"

Describe the bug

I need trailing dot removed: https://github.com/StackExchange/dnscontrol/issues/3089 @kallsyms needs them on: https://github.com/StackExchange/dnscontrol/pull/3151

Using main or v1.14.0, I get this error:

WARN: In v4.15 --cmode will default to "concurrent". Please test and report any bugs ASAP. In v4.16 or later, "legacy" will go away. See https://docs.dnscontrol.org/commands/preview-push
******************** Domain: example.co.uk
ERROR: ERROR: error while getting Nameservers for zone="example.co.uk" with provider="oracle": provider code leaves trailing dot on nameserver
Done. 0 corrections.

Using v1.13.0, all fine:

******************** Domain: example.co.uk
Done. 0 corrections.

To Reproduce

go install github.com/StackExchange/dnscontrol/v4@main
dnscontrol preview

works for @kallsyms , error for @fabienmazieres

go install github.com/StackExchange/dnscontrol/v4@v4.13.0
dnscontrol preview

error for @kallsyms , works for @fabienmazieres

Note: I have actually build both providers separately to make it easier to test with either one or the other:

cd <GOPATH>\pkg\mod\github.com\!stack!exchange\dnscontrol\v4@v4.13.0
go build -o <GOPATH>\bin\dnscontrol.v4.13.0.exe
cd ..\v4@v4.14.0\
go build -o <GOPATH>\bin\dnscontrol.v4.14.0.exe

Expected behavior

behavior should be consistent.

DNS Provider

  • ORACLE

Additional context

I get the same behavior on my machine (Windows) and on a GitHub runner (Ubuntu) so I do not think it is linked to the OS, except if @kallsyms is using Mac? Could it be linked to the Oracle config? Can we have a variable used to control whether to use or the other function? This may need to be set at a global level to apply to all domains, or at a domain level

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 18 (16 by maintainers)

Most upvoted comments

(Tip: Configure your code editor to run goimports (instead of gofmt) and those problems go away)