Squirrel.Windows: CreateZipFromDirectory exception on macOS Catalina (10.15)

Squirrel version(s) 1.9.1 (as bundled in electron-winstaller 4.0.0)

Description

On macOS Catalina (10.15), 32-bit apps such as 32-bit wine can no longer be run. This means that running Windows apps with wine will not work. Instead, it should be using wine64.

Steps to recreate

On macOS 10.15:

Make sure wine-stable and mono are installed (brew cask install xquartz wine-stable mono)
Either:
- use electron-winstaller, or
- run wine Squirrel.exe --releasify MyApp.1.0.0.nupkg

Expected behavior

Executes normally.

Actual behavior

Output:

Error {
    message: `Failed with exit code: 255␊

    Output:␊
    System.AggregateException: One or more errors occurred. () ---> System.Exception␊
      at Squirrel.Utility.CreateZipFromDirectory (System.String zipFilePath, System.String inFolder) [0x00119] in <a5ee691170b94c488950c75951ce1ba3>:0 ␊
       --- End of inner exception stack trace ---␊
      at System.Threading.Tasks.Task.ThrowIfExceptional (System.Boolean includeTaskCanceledExceptions) [0x00011] in <b6f643ae6ccb410db69142d5eaf9b9c1>:0 ␊
      at System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout, System.Threading.CancellationToken cancellationToken) [0x00043] in <b6f643ae6ccb410db69142d5eaf9b9c1>:0 ␊
      at System.Threading.Tasks.Task.Wait () [0x00000] in <b6f643ae6ccb410db69142d5eaf9b9c1>:0 ␊
      at Squirrel.ReleasePackage.CreateReleasePackage (System.String outputFile, System.String packagesRootDir, System.Func`2[T,TResult] releaseNotesProcessor, System.Action`1[T] contentsPostProcessHook) [0x001f7] in <a5ee691170b94c488950c75951ce1ba3>:0 ␊
      at Squirrel.Update.Program.Releasify (System.String package, System.String targetDir, System.String packagesDir, System.String bootstrapperExe, System.String backgroundGif, System.String signingOpts, System.String baseUrl, System.String setupIcon, System.Boolean generateMsi, System.String frameworkVersion, System.Boolean generateDeltas) [0x00214] in <a5ee691170b94c488950c75951ce1ba3>:0 ␊
      at Squirrel.Update.Program.executeCommandLine (System.String[] args) [0x004a2] in <a5ee691170b94c488950c75951ce1ba3>:0 ␊
      at Squirrel.Update.Program.main (System.String[] args) [0x00082] in <a5ee691170b94c488950c75951ce1ba3>:0 ␊
      at Squirrel.Update.Program.Main (System.String[] args) [0x00006] in <a5ee691170b94c488950c75951ce1ba3>:0 ␊
    ---> (Inner Exception #0) System.Exception␊
      at Squirrel.Utility.CreateZipFromDirectory (System.String zipFilePath, System.String inFolder) [0x00119] in <a5ee691170b94c488950c75951ce1ba3>:0 <---␊
    `,
  }

Additional information

CI output where this occurred: https://app.circleci.com/pipelines/github/electron/windows-installer/81/workflows/fa34897f-dfa9-4a50-856a-34d3c1804c12/jobs/126

To work around this, I’m using macOS 10.14 in CI, but that doesn’t help folks who are trying to use electron-winstaller on Catalina.

I suspect it has something to do with this:

https://github.com/Squirrel/Squirrel.Windows/blob/1b7220b3efd9abeaa0b07a0d04c02d2a54b9b585/src/Squirrel/Utility.cs#L399-L402

My suggestion is to either:

check the arch at runtime and set wine or wine64 accordingly
use the WINE environment variable and fall back to wine

About this issue

Original URL
State: open
Created 4 years ago
Reactions: 43
Comments: 18 (1 by maintainers)

Commits related to this issue

Wine64 Support Added Fixed #1605 — committed to detayteknoloji/Squirrel.Windows by abdurrahmanekr 4 years ago

Most upvoted comments

For people still experiencing this issue try this, fixed the CreateZipFromDirectory error for me!

brew uninstall --cask xquartz
brew uninstall --cask wine-stable

brew tap gcenx/wine
brew install --cask --no-quarantine wine-crossover

+50

ToddAlvordMinerva on Apr 18, 2022

Same for me

+10

fabiosoft on Jun 17, 2020

I am waiting a solution for this bug too. 😉

palmadias on May 19, 2020

temporary solution:

brew install 7zip
mkdir wine_proxy
create a file wine_proxy/wine
add execute permission chmod +x wine_proxy/wine
set environment export PATH="$(pwd)/wine_proxy:$PATH"

wine_proxy/wine:

#!/usr/bin/env node
const { spawn } = require('child_process');

const args = process.argv.slice(2);
let cmd = args.shift();
const cwd = process.cwd();

if (cmd.endsWith('7z.exe')) {
    const z7Args = args.filter((v) => v !== 'on');
    spawn('7z', z7Args, { cwd });
} else {
    // cannot use 'wine' loop
    spawn('/opt/homebrew/bin/wine', [cmd, ...args], { cwd });
}

cjahv on Nov 19, 2021

Please don’t add “same issue”-type comments to this issue, it only adds noise to the folks subscribed to it. Instead, please add a reaction to the issue summary.

malept on May 6, 2020

macOS is officially unsupported for Squirrel.Windows - if you get it to work, that’s great, but tbh I recommend getting an actual Windows machine instead because even if you can build your Electron app on macOS, you’re gonna have to test Windows before you ship something. You can set up CI via GitHub Actions to build an installer with some work

anaisbetts on Apr 19, 2022

The workarounds that I know of that reliably work are:

Use a version of macOS before 10.15 (this is what I’m doing in CI for electron-winstaller)
Use a Windows VM
Use a Linux VM/container with 32-bit wine installed

malept on Apr 29, 2020

@mattfbacon I still think you have a separate issue with a misconfigured wine (32 bit vs 64 bit). I would suggest (temporarily?) moving ~/.wine to ~/.wine32 so that the 64-bit version of wine can generate its installation.

Any further questions about your wine install should go to the Arch Linux forum or the Wine forum, since this really isn’t a Wine troubleshooting issue.

malept on Jul 6, 2020