okhttp: Http2Stream to have independent errors for request and response streams

@swankjesse I would like to point out that I have lots of users who are waiting for a fix on this (https://github.com/PhilippC/keepass2android/issues/747), so if it is possible in any way to keep the milestone fixed to 4.5 I’d be really happy, as I have seen this being moved from 4.3 to 4.4 and now 4.5. Anyway: Thanks for your hard work! I really appreciate it and I totally understand that features are shifted to later milestones, so please don’t see this as criticism. I just want to make sure you are aware that this is a real issue for real people 😃

Can fix.

@swankjesse I am running into this issue as well (https://github.com/PhilippC/keepass2android/issues/747). I can reproduce it with the following code:

public class ConnectionInfo {
	public String URL;
	public String username;
	public String password;
}


private OkHttpClient getClient(ConnectionInfo ci) throws NoSuchAlgorithmException, KeyManagementException, KeyStoreException {

	Log.d("KP2AJ","building okhttp client");
	OkHttpClient.Builder builder = new OkHttpClient.Builder();
	final Map<String, CachingAuthenticator> authCache = new ConcurrentHashMap<>();

	com.burgstaller.okhttp.digest.Credentials credentials = new com.burgstaller.okhttp.digest.Credentials(ci.username, ci.password);
	final BasicAuthenticator basicAuthenticator = new BasicAuthenticator(credentials);
	final DigestAuthenticator digestAuthenticator = new DigestAuthenticator(credentials);

	DispatchingAuthenticator authenticator = new DispatchingAuthenticator.Builder()
			.with("digest", digestAuthenticator)
			.with("basic", basicAuthenticator)
			.build();

	builder = builder.authenticator(new CachingAuthenticatorDecorator(authenticator, authCache))
			.pingInterval(1, TimeUnit.SECONDS)
			.writeTimeout(100, TimeUnit.SECONDS)
			.connectTimeout(100, TimeUnit.SECONDS)
			.readTimeout(100, TimeUnit.SECONDS)
			.addInterceptor(new AuthenticationCacheInterceptor(authCache));

	OkHttpClient client =  builder.build();


	return client;
}

class PerformOkHttpTestTask extends AsyncTask<Object, Void, Void> {


	@Override
	protected Void doInBackground(Object... params) {

		android.util.Log.d("KP2AJ", "upload starting");

		ConnectionInfo ci = new ConnectionInfo();
		ci.password = "xxx";
		ci.URL = "https://...";
		ci.username = "userX";

		byte[] data = new byte[3000000];

		Request request = null;
		try {
			request = new Request.Builder()
					.url(new URL(ci.URL))
					.put(RequestBody.create(MediaType.parse("application/binary"), data))
					.build();


			Response response = null;

			response = getClient(ci).newCall(request).execute();
			if((response.code() < 200)
					|| (response.code() >= 300))
			{
				if (response.code() == 404)
					throw new FileNotFoundException();
				throw new Exception("Received unexpected response: " + response.toString());
			}
			android.util.Log.d("KP2AJ", "upload ok");


		} catch (Exception e) {
			e.printStackTrace();
		}

		return null;
	}
}

 @Override 
protected void onCreate(Bundle savedInstanceState) {
	super.onCreate(savedInstanceState);
	setContentView(R.layout.activity_main);
	
	findViewById(R.id.button1).setOnClickListener(new OnClickListener() {
        public void onClick(View v) {
        	new PerformOkHttpTestTask().execute();
        }
    });

Note that this issue also occurs without the pingInterval and read/write/connectTimeout calls on the builder. Note that it does not occur if I upload less data (e.g. 3000 bytes instead of 3MB).

The server I am testing this with is an Server version: Apache/2.4.25 (Raspbian) Server built: 2019-10-13T15:43:54 Nextcloud Version 16.0.3

My build.gradle has

 dependencies {
     compile 'com.squareup.okhttp3:okhttp:4.2.2'
     compile 'com.burgstaller:okhttp-digest:1.15'
 }

As many of my users (of Keepass2Android) are waiting for a fix to this: Is there anything I can change in my code or a workaround you can suggest?

Is the sample code enough or do you need a full Android Studio project?

Thanks a lot!

@michaelbannister yeah, I wanna cut a 4.x release very soon. I’ll make sure to include this fix.