sqldelight: SQLiteException: cannot start a transaction within a transaction
SQLDelight Version
2.0.0-rc2
Application Operating System
Android
Describe the Bug
When running multiple queries in parallel, each in a separate transaction, an exception is thrown sometimes.
The code I’m running is
val table1Data = async { /* ...(1)... */ }
val table2Data = async { /* ...(1)... */ }
// (1) :
withContext(Dispatchers.IO) { queries.transactionWithResult { queries.getAllUpdatedAfter().executeAsOne() } } // noEnclosing = false
Is there anything wrong with my setup? This issue appeared recently after migrating from alpha to rc. But I suppose I may have made breaking changes myself while I was migrating.
Stacktrace
Non-fatal Exception: android.database.sqlite.SQLiteException: cannot start a transaction within a transaction (code 1 SQLITE_ERROR)
at android.database.sqlite.SQLiteConnection.nativeExecute(SQLiteConnection.java)
at android.database.sqlite.SQLiteConnection.execute(SQLiteConnection.java:730)
at android.database.sqlite.SQLiteSession.beginTransactionUnchecked(SQLiteSession.java:321)
at android.database.sqlite.SQLiteSession.beginTransaction(SQLiteSession.java:300)
at android.database.sqlite.SQLiteDatabase.beginTransaction(SQLiteDatabase.java:738)
at android.database.sqlite.SQLiteDatabase.beginTransactionNonExclusive(SQLiteDatabase.java:672)
at androidx.sqlite.db.framework.FrameworkSQLiteDatabase.beginTransactionNonExclusive(FrameworkSQLiteDatabase.kt:59)
at app.cash.sqldelight.driver.android.AndroidSqliteDriver.newTransaction(AndroidSqliteDriver.java:114)
at app.cash.sqldelight.TransacterImpl.transactionWithWrapper(TransacterImpl.java:360)
at app.cash.sqldelight.TransacterImpl.transactionWithResult(TransacterImpl.java:356)
at app.cash.sqldelight.Transacter$DefaultImpls.transactionWithResult$default(Transacter.java:83)
at com.app.util.DatabaseUtilKt$suspendTransaction$2.invokeSuspend$$forInline(DatabaseUtil.kt:18)
at com.app.util.dao.DaoImpl$getAllUpdatedAfter$$inlined$invoke$default$1.invokeSuspend(DatabaseUtil.kt:18)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.java:115)
at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.java:584)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)
About this issue
- Original URL
- State: open
- Created 3 years ago
- Reactions: 1
- Comments: 16 (1 by maintainers)
No, @tamimattafi. We are still using a single thread dispatcher for all queries.
Just open 2 transactions in async and the driver raise this error. It’s like the driver try to run the transactions in a same thread and open a new transaction inside the first one.
Same with threads, just start 2 transactions in 2 threads, and the driver run the second transaction in the first one.
Exception in thread “Thread-6” org.sqlite.SQLiteException: [SQLITE_ERROR] SQL error or missing database (cannot start a transaction within a transaction)
In SQLDelight 2.0.0, to prevent this issue, I used a custom Dispatcher for my database request, limited to one parallelism.
But, of course, I break the parallelism of async in this temporary solution. And only one request can run at the same time. I will return easily to the Dispatcher.IO when the fix will be done.