spring-security: SecurityContextHolderFilter does not apply to async dispatch
Describe the bug
My app currently runs on Spring Boot 2.7.4. I was testing compatibility with 3.0.0-M5. All appeared to work well except one aspect of spring-security, as part of presenting a client certificate using WebClient. I end up with “AccessDeniedException: Access is denied” thrown by AffirmativeBased.decide(AffirmativeBased.java:73). The handshake appears to work fine, and the handshake logging looks nearly identical to that under 2.7.4. But I got it to work after downgrading to spring-security:6.0.0-M5 (from M7). So, it seems something broke as of spring-security:6.0.0-M6. Is this a known issue, and will it be fixed in the next spring-security release?
To Reproduce
- Under standard configuration of Spring Boot 3.0.0-M5, which includes spring-security:6.0.0-M7 (or even downgrading to M6), run the code below against a URL resource protected by client certificate authorization
- Witness AccessDeniedException: Access is denied" thrown by AffirmativeBased.decide(AffirmativeBased.java:73)
Expected behavior
Client certificate authentication succeeds… as it does under both Spring Boot 2.7.4 and 3.0.0-M5 with spring-security downgraded to 6.0.0-M5 (from 6.0.0-M7)
Sample
private StreamingResponseBody streamUrl(final String url) {
final String keyStoreResourcePath = "[url resource path to key/trust store]", keyStorePass = "[some password]";
final HttpClient httpClient = HttpClient.create().secure(spec -> {
try {
final char[] keyStorePassChars = keyStorePass.toCharArray();
final URL keyStoreUrl = ResourceUtils.getURL(keyStoreResourcePath);
final KeyStore keyStore = KeyStore.getInstance("PKCS12");
keyStore.load(keyStoreUrl.openStream(), keyStorePassChars);
final KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());
keyManagerFactory.init(keyStore, keyStorePassChars);
final TrustManagerFactory trustManagerFactory = InsecureTrustManagerFactory.INSTANCE;
spec.sslContext(Http2SslContextSpec.forClient().configure(sslContextBuilder -> sslContextBuilder.keyManager(keyManagerFactory).trustManager(trustManagerFactory)));
} catch (final NoSuchAlgorithmException | KeyStoreException | CertificateException | UnrecoverableKeyException | IOException e) {
throw new IllegalStateException("Boom!", e);
}
});
final WebClient client = WebClient.builder().clientConnector(new ReactorClientHttpConnector(httpClient)).baseUrl(url).build();
final Flux<DataBuffer> dataBufferFlux = client.get()
.accept(MediaType.APPLICATION_PDF)
.retrieve()
.bodyToFlux(DataBuffer.class);
return out -> DataBufferUtils.write(dataBufferFlux, out).doOnNext(DataBufferUtils.releaseConsumer()).blockLast(Duration.ofSeconds(20));
}
@GetMapping(path = "/docs/{docId}", produces = MediaType.APPLICATION_PDF_VALUE)
public ResponseEntity<StreamingResponseBody> stream(@PathVariable final String docId) {
final String url = lookupUrlGivenDocId(docId); //Some client cert auth protected document URL being streamed on behalf of the client
return ResponseEntity.ok().contentType(MediaType.APPLICATION_PDF).body(streamUrl(url));
}
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 32 (13 by maintainers)
Commits related to this issue
- Apply SecurityContextHolderFilter to all dispatcher types Closes gh-11962 — committed to marcusdacoregio/spring-security by marcusdacoregio 4 years ago
- Apply SecurityContextHolderFilter to all dispatcher types Closes gh-11962 — committed to spring-projects/spring-security by marcusdacoregio 4 years ago
- Fix 403 response for async dispatch endpoints :) (https://github.com/spring-projects/spring-security/issues/11962) — committed to rubenboadana/java-modulith-cqrs-pub_sub-example by rubenboadana 3 years ago
in Spring Security 6.3.1 this configuration works for us:
Hi @kotharikrati, you should not need the workaround anymore if you are using the latest version of Spring Security or at least >= 5.8.1 or >= 6.0.1. If you have the same error it is likely another thing is happening, please add
logging.level.org.springframework.security=TRACEto yourapplication.propertiesand check what is happening.Hi @marcusdacoregio , the overridden method : @Override protected boolean shouldNotFilterAsyncDispatch() { return false; }
only works for spring 3.0.0 and not for 3.0.6 or 3.0.1. because with Spring Security 6.0.1 onwards , SecurityContextHolderFilter doest not extends OncePerRequestFilter.
How can I fix the issue in this case? Can we have another fix for higher versions?
Thank you @fkbeys for the detailed solution of yours.
Although I applied all the solutions on the internet, I still could not solve the problem.
Synchronous method in my controller works normally. But the asynchronous method gives an authentication error every time. However, both methods do the same job and get the same Token. The codes of my project are available below. I think the bug is still not resolved.
https://github.com/fkbeys/javasprinasyncauthproblem
@marcusdacoregio I tried the filter as well, and it works for me too.
@marcusdacoregio So with the filter I no longer have the exception.