spring-framework: Request data binding fails for params with an empty array "[]" suffix

Hello, It seems like a bug.

org.sprinframework:spring-beans:5.2.8.RELEASE

We use filterDto in our controller.

data class FilteDto(
var types: MutableList<String>
)

But when we build our request like this types[]=first_type&types[]=second_type. Tokens keys in propertyTokenHolder are wrong. They are just one empty string “”. And then we get such output Illegal request output.

We got such stacktrace.

java.lang.NumberFormatException: For input string: ""
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) ~[na:na]
	at java.base/java.lang.Integer.parseInt(Integer.java:662) ~[na:na]
	at java.base/java.lang.Integer.parseInt(Integer.java:770) ~[na:na]
	at org.springframework.beans.AbstractNestablePropertyAccessor.processKeyedProperty(AbstractNestablePropertyAccessor.java:322) ~[spring-beans-5.2.8.RELEASE.jar:5.2.8.RELEASE]
	at org.springframework.beans.AbstractNestablePropertyAccessor.setPropertyValue(AbstractNestablePropertyAccessor.java:275) ~[spring-beans-5.2.8.RELEASE.jar:5.2.8.RELEASE]
	at org.springframework.beans.AbstractNestablePropertyAccessor.setPropertyValue(AbstractNestablePropertyAccessor.java:266) ~[spring-beans-5.2.8.RELEASE.jar:5.2.8.RELEASE]
	at org.springframework.beans.AbstractPropertyAccessor.setPropertyValues(AbstractPropertyAccessor.java:97) ~[spring-beans-5.2.8.RELEASE.jar:5.2.8.RELEASE]
	at org.springframework.validation.DataBinder.applyPropertyValues(DataBinder.java:848) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
	at org.springframework.validation.DataBinder.doBind(DataBinder.java:744) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
	at org.springframework.web.bind.WebDataBinder.doBind(WebDataBinder.java:197) ~[spring-web-5.2.8.RELEASE.jar:5.2.8.RELEASE]

I think problem in AbstractNestablePropertyAccessor. In getPropertyNameTokens, see 928 line in AbstractNestablePropertyAccessor.

Maybe in this line.

	if (key.length() > 1 && (key.startsWith("'") && key.endsWith("'")) ||
							(key.startsWith("\"") && key.endsWith("\""))) {
						key = key.substring(1, key.length() - 1);
					}
					keys.add(key);

P.S. When we search like this types=first_type&types=second_type all is fine.

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 17 (10 by maintainers)

Most upvoted comments

Team Decision: We’ll drop such a “[]” suffix for web data binding purposes before passing the input to the bean binding infrastructure. The suffix cannot have any other sensible meaning and it would fail currently anyway.