spring-cloud-zookeeper: Regression in `3.1.4`: customizations to the `CuratorFramework` instance are now silently ignored
Describe the bug
spring-cloud-zookeeper release 3.1.4 introduced a regression. There were ways to customize the CuratorFramework instance that got used, e.g. by injecting a CuratorFrameworkCustomizer via a registry.registerIfAbsent call in a custom BootstrapRegistryInitializer that runs before ZookeeperConfigServerBootstrapper. Such customizations worked flawlessly until version 3.1.3, but in 3.1.4 they are now silently ignored.
It doesn’t look like there is an easy way to apply such customizations in the new version, other than copying the old registry.registerIfAbsent(ConfigServerInstanceProvider.Function.class, ...) code from the PR and overriding the new ZookeeperFunction::create implementation with it.
This change should be reverted; even if it makes sense to do this, it most definitely doesn’t belong in a patch release. Thanks.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 16 (9 by maintainers)
Commits related to this issue
- Support to use classes registered in bootstrap context. Fixes #324 — committed to ryanjbaxter/spring-cloud-zookeeper by ryanjbaxter 3 years ago
- Support to use classes registered in bootstrap context. Fixes #324 (#325) Co-authored-by: Ryan Baxter <524254+ryanjbaxter@users.noreply.github.com> — committed to spring-cloud/spring-cloud-zookeeper by deleted user 3 years ago
Correct. And of course we could consider a release if there was a huge demand for a fix, but as of right now there is not
Agree it was super helpful!
Thanks @pantherdd for taking the time to make the reproducer!
Yeah it doesnt have to do anything useful, just show that it was used in 3.1.3, but is no longer used in 3.1.4 (it could just print something to the console to show that)
It was part of https://github.com/spring-cloud/spring-cloud-commons/pull/1228 and https://github.com/spring-cloud/spring-cloud-config/issues/1922
@ryanjbaxter any ideas?