spring-cloud-netflix: Unable to build or run all tests successfully on windows
Hi,
I cloned master and tried mvnw install but have not been able to get it running successfully - complains about failed tests in ‘Spring Cloud Netflix core’. Have also tried running all tests from within Spring IDE, still the same tests fail.
org.springframework.cloud.netflix.feign.support.SpringMvcContractTests.txt org.springframework.cloud.netflix.feign.valid.FeignOkHttpTests.txt org.springframework.cloud.netflix.metrics.MetricsRestTemplateTests.txt org.springframework.cloud.netflix.resttemplate.RestTemplateRetryTests.txt org.springframework.cloud.netflix.ribbon.okhttp.SpringRetryDisableOkHttpClientTests.txt org.springframework.cloud.netflix.ribbon.okhttp.SpringRetryEnabledOkHttpClientTests.txt org.springframework.cloud.netflix.ribbon.RibbonClientConfigurationTests.txt org.springframework.cloud.netflix.ribbon.RibbonClientHttpRequestFactoryTests.txt org.springframework.cloud.netflix.ribbon.SpringClientFactoryTests.txt org.springframework.cloud.netflix.zuul.filters.route.okhttp.OkHttpRibbonRetryIntegrationTests.txt org.springframework.cloud.netflix.zuul.filters.route.restclient.RestClientRibbonCommandIntegrationTests.txt
Are there any services that I need to run for the above tests to pass? Can’t find any documentation about that, can someone kindly help and point me in the right direction?
I am not on Linux - using Windows 10, if that makes any difference.
Thank you
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 27 (16 by maintainers)
Commits related to this issue
- Ensure ordering of ribbon client configuration. On certain platforms and compilers the generated bytecode is not what the configuration expected. By moving inner classes to the upper level and using ... — committed to spring-cloud/spring-cloud-netflix by spencergibb 7 years ago
- Ensure ordering of feign ribbon client configuration. On certain platforms and compilers the generated bytecode is not what the configuration expected. By moving inner classes to the upper level and ... — committed to spring-cloud/spring-cloud-netflix by spencergibb 7 years ago
It looks like
RibbonClientConfigurationis assuming that its inner classes will be considered in the order in which they are declared in the source code. That’s not a safe assumption to make. It’s entirely dependant on the byte code produced by the compiler and how ASM loads that byte code. You either need to make the property conditions mutually exclusive, or move the configurations to top-level classes and use@Importwhich does provide ordering guarantees.