spinnaker: Manifests cannot be interpolated from SPEL expression in `Deploy (Manifest)` steps

Issue Summary:

Steps of type Deploy (Manifest) do not work when a SPEL expression is specified in the text area of the manifest. This worked at least until v1.26.3.

Cloud Provider(s):

Kubernetes

Environment:

Spinnaker 1.27.0, 1.27.1, 1.28.0, 1.28.1

Feature Area:

Pipelines

Description:

Steps to Reproduce:

  1. Create a new pipeline using the following json:
Example pipeline
{ "appConfig": {}, "keepWaitingPipelines": false, "lastModifiedBy": "sepulvedablanco", "limitConcurrent": true, "parameterConfig": [ { "default": "", "description": "k8s cluster id", "hasOptions": false, "label": "k8s cluster id", "name": "account", "options": [ { "value": "" } ], "pinned": true, "required": true } ], "schema": "1", "spelEvaluator": "v4", "stages": [ { "failOnFailedExpressions": true, "name": "Evaluate Variables", "refId": "1", "requisiteStageRefIds": [], "type": "evaluateVariables", "variables": [ { "key": "cm_b64", "value": "YXBpVmVyc2lvbjogdjEKZGF0YToKICBnYW1lLnByb3BlcnRpZXM6IHwKICAgIGVuZW1pZXM9YWxpZW5zCmtpbmQ6IENvbmZpZ01hcAptZXRhZGF0YToKICBuYW1lOiBnYW1lLWNvbmZpZwogIG5hbWVzcGFjZTogZGVmYXVsdAo=" }, { "key": "cm", "value": "${#fromBase64(cm_b64)}" }, { "key": "cm_json", "value": "${#readYaml(cm)}" } ] }, { "account": "${parameters.account}", "cloudProvider": "kubernetes", "completeOtherBranchesThenFail": false, "continuePipeline": true, "failPipeline": false, "manifests": [ "${cm_json}" ], "moniker": { "app": "${execution.application}" }, "name": "Test deploy from text with var", "namespaceOverride": "", "refId": "2", "requisiteStageRefIds": [ "1" ], "skipExpressionEvaluation": false, "source": "text", "trafficManagement": { "enabled": false, "options": { "enableTraffic": false, "services": [] } }, "type": "deployManifest" } ], "triggers": [] }
  1. Execute the pipeline specifying as a parameter the clouddriver account to use to apply the manifest.

  2. The pipeline will fail on the step of type Deploy (Manifest) with the following error:

Exception
Unable to map context to class com.netflix.spinnaker.orca.clouddriver.tasks.manifest.DeployManifestContext

As the following screenshot shows:

Captura desde 2022-09-02 17-14-47

Additional Details:

Emphasize that this functionality works correctly at least until v1.26.3.

Orca log exception:

Error occurred during task Test deploy from text with var:ConstructAfterStages
java.lang.IllegalArgumentException: Unable to map context to class com.netflix.spinnaker.orca.clouddriver.tasks.manifest.DeployManifestContext
	at com.netflix.spinnaker.orca.pipeline.model.StageExecutionImpl.mapTo(StageExecutionImpl.java:596)
	at com.netflix.spinnaker.orca.pipeline.model.StageExecutionImpl.mapTo(StageExecutionImpl.java:578)
	at com.netflix.spinnaker.orca.clouddriver.pipeline.manifest.DeployManifestStage.afterStages(DeployManifestStage.java:72)
	at com.netflix.spinnaker.orca.q.StageDefinitionBuildersKt.buildAfterStages(StageDefinitionBuilders.kt:120)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.planAfterStages(CompleteStageHandler.kt:205)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.access$planAfterStages(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler$handle$1$1.invoke(CompleteStageHandler.kt:102)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler$handle$1$1.invoke(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.orca.q.handler.AuthenticationAware$sam$java_util_concurrent_Callable$0.call(AuthenticationAware.kt)
	at com.netflix.spinnaker.security.AuthenticatedRequest.lambda$wrapCallableForPrincipal$0(AuthenticatedRequest.java:272)
	at com.netflix.spinnaker.orca.q.handler.AuthenticationAware$DefaultImpls.withAuth(AuthenticationAware.kt:51)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.withAuth(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler$handle$1.invoke(CompleteStageHandler.kt:101)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler$handle$1.invoke(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.orca.q.handler.OrcaMessageHandler$withStage$1.invoke(OrcaMessageHandler.kt:86)
	at com.netflix.spinnaker.orca.q.handler.OrcaMessageHandler$withStage$1.invoke(OrcaMessageHandler.kt:46)
	at com.netflix.spinnaker.orca.q.handler.OrcaMessageHandler$DefaultImpls.withExecution(OrcaMessageHandler.kt:96)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.withExecution(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.orca.q.handler.OrcaMessageHandler$DefaultImpls.withStage(OrcaMessageHandler.kt:75)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.withStage(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.handle(CompleteStageHandler.kt:85)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.handle(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.q.MessageHandler$DefaultImpls.invoke(MessageHandler.kt:36)
	at com.netflix.spinnaker.orca.q.handler.OrcaMessageHandler$DefaultImpls.invoke(OrcaMessageHandler.kt)
	at com.netflix.spinnaker.orca.q.handler.CompleteStageHandler.invoke(CompleteStageHandler.kt:72)
	at com.netflix.spinnaker.orca.q.audit.ExecutionTrackingMessageHandlerPostProcessor$ExecutionTrackingMessageHandlerProxy.invoke(ExecutionTrackingMessageHandlerPostProcessor.kt:72)
	at com.netflix.spinnaker.q.QueueProcessor$callback$1$1.run(QueueProcessor.kt:90)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of `java.util.LinkedHashMap` (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('${cm_json}')
 at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: com.netflix.spinnaker.orca.clouddriver.tasks.manifest.DeployManifestContext$DeployManifestContextBuilder["manifests"]->java.util.ArrayList[0])
	at com.fasterxml.jackson.databind.exc.MismatchedInputException.from(MismatchedInputException.java:63)
	at com.fasterxml.jackson.databind.DeserializationContext.reportInputMismatch(DeserializationContext.java:1588)
	at com.fasterxml.jackson.databind.DeserializationContext.handleMissingInstantiator(DeserializationContext.java:1213)
	at com.fasterxml.jackson.databind.deser.std.StdDeserializer._deserializeFromString(StdDeserializer.java:311)
	at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:444)
	at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:32)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeFromArray(CollectionDeserializer.java:355)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:244)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:28)
	at com.fasterxml.jackson.databind.deser.impl.MethodProperty.deserializeSetAndReturn(MethodProperty.java:158)
	at com.fasterxml.jackson.databind.deser.BuilderBasedDeserializer.vanillaDeserialize(BuilderBasedDeserializer.java:293)
	at com.fasterxml.jackson.databind.deser.BuilderBasedDeserializer.deserialize(BuilderBasedDeserializer.java:217)
	at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:322)
	at com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:4569)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2798)
	at com.netflix.spinnaker.orca.pipeline.model.StageExecutionImpl.mapTo(StageExecutionImpl.java:591)
	... 29 common frames omitted

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Comments: 21 (12 by maintainers)

Most upvoted comments