spglib: Most of warning_print should should not be displayed.

As @LecrisUT mentions at #336, warning_print is on by default. But I think most of them should not be displayed by default, but ideally this should be conditional. @LecrisUT, do you know a good way to make it conditional?

About this issue

  • Original URL
  • State: closed
  • Created 9 months ago
  • Comments: 20

Commits related to this issue

Most upvoted comments

getenv("SPGLIB_WARNING"). Probably more natural to be SPGLIB_DEBUG or SPGLIB_LOG

but at least through the python warnings package or through stdout/stderr, neither of which is currently possible

If we make progress on the C++ interface, I know how to handle it more nicely to have pyrhon native warnings with spdlog.

In the meantime I hope hacking up different message prints would help. I couldn’t find a straightforward way to classify info/warning/debug so there might take some iterations and feedback to get things right.

Hi! Thanks for your work on this incredibly useful package. Just to mention, we have also run into some of these warnings recently with our defects code doped which relies on spglib through the pymatgen interface. In these cases, the result is still correct, just a stream of warnings are printed as spglib dynamically adjusts the tolerance. It would be much preferred if we could avoid these warnings!