pyspedas: Some PySPEDAS unit tests fail in PyHC Environment

Greetings PySPEDAS team,

I’m opening this issue in response to a conversation we had at the last PyHC core developer tag-up.

The PyHC environment is now deployed in Binder: https://binder.opensci.2i2c.cloud/v2/gh/heliophysicsPy/science-platforms-coordination/pyhc

Included in there is a notebook unit-tests.ipynb which runs core package unit tests.

Currently, 90.62% of PySPEDAS’s tests pass when I run that notebook. Will you please look at what fails and help me bring that up to 100%?

You can click the link above to launch the environment and run the unit tests yourself. But if the link hasn’t been clicked in a while it can take upwards of ten minutes to spin up. This is unfortunate but normal. For convenience I ran the notebook and uploaded it here so you can view the output without waiting.

Please take a look, see what’s failing, and let me know 1) if I should update the environment somehow to get 100% of PySPEDAS’s tests passing or 2) if you can fix them in a new release.

Thank you! Shawn

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 15 (7 by maintainers)

Most upvoted comments

@jameswilburlewis I can confirm, your tests pass 100% now in the PyHC env. Thanks for working on this!

Thanks @jiashuwu89. I re-ran it and the ELFIN tests pass. Now the only failures are the 4 twavpol ones.

I put the output in a notebook here if you wanna quickly see it.

I’ll let them know about the server issue and keep you updated. Thanks @sapols