taxonworks: [Bug]: DWCA Checklist Importer: fails to import records with no scientificNameAuthorship
Steps to reproduce the bug
- When clicking the import button on a DWCA record with an empty scientificNameAuthorship
- A javascript error modal is raised with the below stack trace
NoMethodError at /import_datasets/108/import.json ================================================= undefined method `match' for nil:NilClass > To access an interactive console with this error, point your browser to: /__better_errors app/models/dataset_record/darwin_core/taxon.rb, line 61 ------------------------------------------------------- ``` ruby 56 author_name = nil 57 year = nil 58 59 # split authorship into name and year 60 if nomenclature_code == :iczn > 61 if (authorship_matchdata = authorship.match(/\(?(?.+),? (?\d{4})?\)?/)) 62 63 # regex will include comma, no easy way around it 64 author_name = authorship_matchdata[:author].delete_suffix(',') 65 year = authorship_matchdata[:year] 66 ``` App backtrace ------------- - app/models/dataset_record/darwin_core/taxon.rb:61:in `block in import' - app/models/dataset_record/darwin_core/taxon.rb:26:in `import' - app/models/import_dataset/darwin_core.rb:156:in `block (2 levels) in import' - app/models/import_dataset/darwin_core.rb:155:in `block in import' - app/models/import_dataset/darwin_core.rb:95:in `block in start_import' - app/models/import_dataset/darwin_core.rb:83:in `start_import' - app/models/import_dataset/darwin_core.rb:129:in `import' - app/controllers/import_datasets_controller.rb:23:in `import' Full backtrace -------------- - app/models/dataset_record/darwin_core/taxon.rb:61:in `block in import' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/dataNoMethodError at /import_datasets/108/import.json ================================================= undefined method `match' for nil:NilClass > To access an interactive console with this error, point your browser to: /__better_errors app/models/dataset_record/darwin_core/taxon.rb, line 61 ------------------------------------------------------- ``` ruby 56 author_name = nil 57 year = nil 58 59 # split authorship into name and year 60 if nomenclature_code == :iczn > 61 if (authorship_matchdata = authorship.match(/\(?(?.+),? (?\d{4})?\)?/)) 62 63 # regex will include comma, no easy way around it 64 author_name = authorship_matchdata[:author].delete_suffix(',') 65 year = authorship_matchdata[:year] 66 ``` App backtrace ------------- - app/models/dataset_record/darwin_core/taxon.rb:61:in `block in import' - app/models/dataset_record/darwin_core/taxon.rb:26:in `import' - app/models/import_dataset/darwin_core.rb:156:in `block (2 levels) in import' - app/models/import_dataset/darwin_core.rb:155:in `block in import' - app/models/import_dataset/darwin_core.rb:95:in `block in start_import' - app/models/import_dataset/darwin_core.rb:83:in `start_import' - app/models/import_dataset/darwin_core.rb:129:in `import' - app/controllers/import_datasets_controller.rb:23:in `import' Full backtrace -------------- - app/models/dataset_record/darwin_core/taxon.rb:61:in `block in import' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `block in transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:319:in `block in within_new_transaction' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:317:in `within_new_transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `transaction' - activerecord (6.1.7.6) lib/active_record/transactions.rb:209:in `transaction' - app/models/dataset_record/darwin_core/taxon.rb:26:in `import' - app/models/import_dataset/darwin_core.rb:156:in `block (2 levels) in import' - activerecord (6.1.7.6) lib/active_record/relation/delegation.rb:88:in `each' - app/models/import_dataset/darwin_core.rb:155:in `block in import' - app/models/import_dataset/darwin_core.rb:95:in `block in start_import' - activerecord (6.1.7.6) lib/active_record/locking/pessimistic.rb:88:in `block in with_lock' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `block in transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:319:in `block in within_new_transaction' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:317:in `within_new_transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `transaction' - activerecord (6.1.7.6) lib/active_record/transactions.rb:209:in `transaction' - activerecord (6.1.7.6) lib/active_record/transactions.rb:290:in `transaction' - activerecord (6.1.7.6) lib/active_record/locking/pessimistic.rb:86:in `with_lock' - app/models/import_dataset/darwin_core.rb:83:in `start_import' - app/models/import_dataset/darwin_core.rb:129:in `import' - app/controllers/import_datasets_controller.rb:23:in `import' - actionpack (6.1.7.6) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action' - actionpack (6.1.7.6) lib/abstract_controller/base.rb:228:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/rendering.rb:30:in `process_action' - actionpack (6.1.7.6) lib/abstract_controller/callbacks.rb:42:in `block in process_action' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:117:in `block in run_callbacks' - actiontext (6.1.7.6) lib/action_text/rendering.rb:20:in `with_renderer' - actiontext (6.1.7.6) lib/action_text/engine.rb:59:in `block (4 levels) in ' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:126:in `block in run_callbacks' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:137:in `run_callbacks' - actionpack (6.1.7.6) lib/abstract_controller/callbacks.rb:41:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/rescue.rb:22:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/instrumentation.rb:34:in `block in process_action' - activesupport (6.1.7.6) lib/active_support/notifications.rb:203:in `block in instrument' - activesupport (6.1.7.6) lib/active_support/notifications/instrumenter.rb:24:in `instrument' - activesupport (6.1.7.6) lib/active_support/notifications.rb:203:in `instrument' - actionpack (6.1.7.6) lib/action_controller/metal/instrumentation.rb:33:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/params_wrapper.rb:249:in `process_action' - activerecord (6.1.7.6) lib/active_record/railties/controller_runtime.rb:27:in `process_action' - actionpack (6.1.7.6) lib/abstract_controller/base.rb:165:in `process' - actionview (6.1.7.6) lib/action_view/rendering.rb:39:in `process' - actionpack (6.1.7.6) lib/action_controller/metal.rb:190:in `dispatch' - actionpack (6.1.7.6) lib/action_controller/metal.rb:254:in `dispatch' - actionpack (6.1.7.6) lib/action_dispatch/routing/route_set.rb:50:in `dispatch' - actionpack (6.1.7.6) lib/action_dispatch/routing/route_set.rb:33:in `serve' - actionpack (6.1.7.6) lib/action_dispatch/journey/router.rb:50:in `block in serve' - actionpack (6.1.7.6) lib/action_dispatch/journey/router.rb:32:in `serve' - actionpack (6.1.7.6) lib/action_dispatch/routing/route_set.rb:842:in `call' - rack (2.2.8) lib/rack/tempfile_reaper.rb:15:in `call' - rack (2.2.8) lib/rack/etag.rb:27:in `call' - rack (2.2.8) lib/rack/conditional_get.rb:40:in `call' - rack (2.2.8) lib/rack/head.rb:12:in `call' - actionpack (6.1.7.6) lib/action_dispatch/http/permissions_policy.rb:22:in `call' - actionpack (6.1.7.6) lib/action_dispatch/http/content_security_policy.rb:19:in `call' - rack (2.2.8) lib/rack/session/abstract/id.rb:266:in `context' - rack (2.2.8) lib/rack/session/abstract/id.rb:260:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/cookies.rb:697:in `call' - activerecord (6.1.7.6) lib/active_record/migration.rb:601:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:98:in `run_callbacks' - actionpack (6.1.7.6) lib/action_dispatch/middleware/callbacks.rb:26:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/executor.rb:14:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/actionable_exceptions.rb:18:in `call' - better_errors (2.10.1) lib/better_errors/middleware.rb:87:in `protected_app_call' - better_errors (2.10.1) lib/better_errors/middleware.rb:82:in `better_errors_call' - better_errors (2.10.1) lib/better_errors/middleware.rb:60:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/debug_exceptions.rb:29:in `call' - web-console (4.2.1) lib/web_console/middleware.rb:132:in `call_app' - web-console (4.2.1) lib/web_console/middleware.rb:28:in `block in call' - web-console (4.2.1) lib/web_console/middleware.rb:17:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call' - railties (6.1.7.6) lib/rails/rack/logger.rb:37:in `call_app' - railties (6.1.7.6) lib/rails/rack/logger.rb:28:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/remote_ip.rb:81:in `call' - request_store (1.5.1) lib/request_store/middleware.rb:19:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/request_id.rb:26:in `call' - rack (2.2.8) lib/rack/method_override.rb:24:in `call' - rack (2.2.8) lib/rack/runtime.rb:22:in `call' - activesupport (6.1.7.6) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/executor.rb:14:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/static.rb:24:in `call' - rack (2.2.8) lib/rack/sendfile.rb:110:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/host_authorization.rb:148:in `call' - rack-cors (2.0.1) lib/rack/cors.rb:102:in `call' - shakapacker (7.0.3) lib/shakapacker/dev_server_proxy.rb:25:in `perform_request' - rack-proxy (0.7.7) lib/rack/proxy.rb:87:in `call' - railties (6.1.7.6) lib/rails/engine.rb:539:in `call' - puma (6.4.0) lib/puma/configuration.rb:272:in `call' - puma (6.4.0) lib/puma/request.rb:100:in `block in handle_request' - puma (6.4.0) lib/puma/thread_pool.rb:378:in `with_force_shutdown' - puma (6.4.0) lib/puma/request.rb:99:in `handle_request' - puma (6.4.0) lib/puma/server.rb:443:in `process_client' - puma (6.4.0) lib/puma/server.rb:241:in `block in run' - puma (6.4.0) lib/puma/thread_pool.rb:155:in `block in spawn_thread' base_statements.rb:320:in `block in transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:319:in `block in within_new_transaction' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:317:in `within_new_transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `transaction' - activerecord (6.1.7.6) lib/active_record/transactions.rb:209:in `transaction' - app/models/dataset_record/darwin_core/taxon.rb:26:in `import' - app/models/import_dataset/darwin_core.rb:156:in `block (2 levels) in import' - activerecord (6.1.7.6) lib/active_record/relation/delegation.rb:88:in `each' - app/models/import_dataset/darwin_core.rb:155:in `block in import' - app/models/import_dataset/darwin_core.rb:95:in `block in start_import' - activerecord (6.1.7.6) lib/active_record/locking/pessimistic.rb:88:in `block in with_lock' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `block in transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:319:in `block in within_new_transaction' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize' - activesupport (6.1.7.6) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/transaction.rb:317:in `within_new_transaction' - activerecord (6.1.7.6) lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `transaction' - activerecord (6.1.7.6) lib/active_record/transactions.rb:209:in `transaction' - activerecord (6.1.7.6) lib/active_record/transactions.rb:290:in `transaction' - activerecord (6.1.7.6) lib/active_record/locking/pessimistic.rb:86:in `with_lock' - app/models/import_dataset/darwin_core.rb:83:in `start_import' - app/models/import_dataset/darwin_core.rb:129:in `import' - app/controllers/import_datasets_controller.rb:23:in `import' - actionpack (6.1.7.6) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action' - actionpack (6.1.7.6) lib/abstract_controller/base.rb:228:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/rendering.rb:30:in `process_action' - actionpack (6.1.7.6) lib/abstract_controller/callbacks.rb:42:in `block in process_action' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:117:in `block in run_callbacks' - actiontext (6.1.7.6) lib/action_text/rendering.rb:20:in `with_renderer' - actiontext (6.1.7.6) lib/action_text/engine.rb:59:in `block (4 levels) in ' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:126:in `block in run_callbacks' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:137:in `run_callbacks' - actionpack (6.1.7.6) lib/abstract_controller/callbacks.rb:41:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/rescue.rb:22:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/instrumentation.rb:34:in `block in process_action' - activesupport (6.1.7.6) lib/active_support/notifications.rb:203:in `block in instrument' - activesupport (6.1.7.6) lib/active_support/notifications/instrumenter.rb:24:in `instrument' - activesupport (6.1.7.6) lib/active_support/notifications.rb:203:in `instrument' - actionpack (6.1.7.6) lib/action_controller/metal/instrumentation.rb:33:in `process_action' - actionpack (6.1.7.6) lib/action_controller/metal/params_wrapper.rb:249:in `process_action' - activerecord (6.1.7.6) lib/active_record/railties/controller_runtime.rb:27:in `process_action' - actionpack (6.1.7.6) lib/abstract_controller/base.rb:165:in `process' - actionview (6.1.7.6) lib/action_view/rendering.rb:39:in `process' - actionpack (6.1.7.6) lib/action_controller/metal.rb:190:in `dispatch' - actionpack (6.1.7.6) lib/action_controller/metal.rb:254:in `dispatch' - actionpack (6.1.7.6) lib/action_dispatch/routing/route_set.rb:50:in `dispatch' - actionpack (6.1.7.6) lib/action_dispatch/routing/route_set.rb:33:in `serve' - actionpack (6.1.7.6) lib/action_dispatch/journey/router.rb:50:in `block in serve' - actionpack (6.1.7.6) lib/action_dispatch/journey/router.rb:32:in `serve' - actionpack (6.1.7.6) lib/action_dispatch/routing/route_set.rb:842:in `call' - rack (2.2.8) lib/rack/tempfile_reaper.rb:15:in `call' - rack (2.2.8) lib/rack/etag.rb:27:in `call' - rack (2.2.8) lib/rack/conditional_get.rb:40:in `call' - rack (2.2.8) lib/rack/head.rb:12:in `call' - actionpack (6.1.7.6) lib/action_dispatch/http/permissions_policy.rb:22:in `call' - actionpack (6.1.7.6) lib/action_dispatch/http/content_security_policy.rb:19:in `call' - rack (2.2.8) lib/rack/session/abstract/id.rb:266:in `context' - rack (2.2.8) lib/rack/session/abstract/id.rb:260:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/cookies.rb:697:in `call' - activerecord (6.1.7.6) lib/active_record/migration.rb:601:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call' - activesupport (6.1.7.6) lib/active_support/callbacks.rb:98:in `run_callbacks' - actionpack (6.1.7.6) lib/action_dispatch/middleware/callbacks.rb:26:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/executor.rb:14:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/actionable_exceptions.rb:18:in `call' - better_errors (2.10.1) lib/better_errors/middleware.rb:87:in `protected_app_call' - better_errors (2.10.1) lib/better_errors/middleware.rb:82:in `better_errors_call' - better_errors (2.10.1) lib/better_errors/middleware.rb:60:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/debug_exceptions.rb:29:in `call' - web-console (4.2.1) lib/web_console/middleware.rb:132:in `call_app' - web-console (4.2.1) lib/web_console/middleware.rb:28:in `block in call' - web-console (4.2.1) lib/web_console/middleware.rb:17:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call' - railties (6.1.7.6) lib/rails/rack/logger.rb:37:in `call_app' - railties (6.1.7.6) lib/rails/rack/logger.rb:28:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/remote_ip.rb:81:in `call' - request_store (1.5.1) lib/request_store/middleware.rb:19:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/request_id.rb:26:in `call' - rack (2.2.8) lib/rack/method_override.rb:24:in `call' - rack (2.2.8) lib/rack/runtime.rb:22:in `call' - activesupport (6.1.7.6) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/executor.rb:14:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/static.rb:24:in `call' - rack (2.2.8) lib/rack/sendfile.rb:110:in `call' - actionpack (6.1.7.6) lib/action_dispatch/middleware/host_authorization.rb:148:in `call' - rack-cors (2.0.1) lib/rack/cors.rb:102:in `call' - shakapacker (7.0.3) lib/shakapacker/dev_server_proxy.rb:25:in `perform_request' - rack-proxy (0.7.7) lib/rack/proxy.rb:87:in `call' - railties (6.1.7.6) lib/rails/engine.rb:539:in `call' - puma (6.4.0) lib/puma/configuration.rb:272:in `call' - puma (6.4.0) lib/puma/request.rb:100:in `block in handle_request' - puma (6.4.0) lib/puma/thread_pool.rb:378:in `with_force_shutdown' - puma (6.4.0) lib/puma/request.rb:99:in `handle_request' - puma (6.4.0) lib/puma/server.rb:443:in `process_client' - puma (6.4.0) lib/puma/server.rb:241:in `block in run' - puma (6.4.0) lib/puma/thread_pool.rb:155:in `block in spawn_thread'
Screenshot
Expected behavior
Ideally records without scientificNameAuthorship should still be importable, but if not it would be better to raise the error in the status column instead of the javascript modal, and continue importing the other status=ready rows.
Additional Screenshots
No response
Environment
Development (native)
Sandbox Used
localhost
Version
6e0b9da0b900c98f51b72c7d831c967bdc864ac7
Browser Used
Firefox 119.0.1
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 17 (17 by maintainers)
Side note -
&&conditional checks can exit in order of calling, so if you do the nil check first then it doesn’t have to do the second comparison.I agree and it was just temporary for debugging purposes.
@gdower @LordFlashmeow I would very strongly recommend that if you start using
Rescuethat you don’t useNoMethodError(in fact we won’t allow it). Create Import specific error classes and raise/catch those please.should be