spack: Installation issue: Paraview @:5.9 failing to apply exodusII-netcdf4.9.0.patch

Steps to reproduce the issue

spack install -u cmake paraview@5.9.1
...
==> Patch /tools/spack/0.21.1/var/spack/repos/builtin/packages/paraview/exodusII-netcdf4.9.0.patch failed.
==> Error: ProcessError: Command exited with status 1:
    '/usr/bin/patch' '-s' '-p' '1' '-i' '/tools/spack/0.21.1/var/spack/repos/builtin/packages/paraview/exodusII-netcdf4.9.0.patch' '-d' '.'

Error message

==> Patch /tools/spack/0.21.1/var/spack/repos/builtin/packages/paraview/exodusII-netcdf4.9.0.patch failed.
==> Error: ProcessError: Command exited with status 1:
    '/usr/bin/patch' '-s' '-p' '1' '-i' '/tools/spack/0.21.1/var/spack/repos/builtin/packages/paraview/exodusII-netcdf4.9.0.patch' '-d' '.'

Information on your system

Additional information

First encountered this error trying to build version 5.8.1, attempted all other version above until I found last failing one. 5.10.0 works.

I fixed it by making this change:

-  patch("exodusII-netcdf4.9.0.patch", when="@:5.10.2")
+ patch("exodusII-netcdf4.9.0.patch", when="@5.10.0:5.10.2")

But i don’t know what are the implications of that patch at runtime.

Tagging maintainers @danlipsa @vicentebolea @kwryankrattiger

General information

  • I have run spack debug report and reported the version of Spack/Python/Platform
  • I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
  • I have uploaded the build log and environment files
  • I have searched the issues of this repo and believe this is not a duplicate

About this issue

  • Original URL
  • State: open
  • Created 3 years ago
  • Comments: 28 (28 by maintainers)

Most upvoted comments

I don’t understand what macros you’re talking about, that’s the definition of the class of the object we are patching. If you mean the H5_VERS_* mentioned in the patch, they are defined in HDF5’s src/H5public.h and here they are:

/* Version numbers */
/**
 * For major interface/format changes
 */
#define H5_VERS_MAJOR 1
/**
 * For minor interface/format changes
 */
#define H5_VERS_MINOR 14
/**
 * For tweaks, bug-fixes, or development
 */
#define H5_VERS_RELEASE 0

Anyway I cannot think of a single reason a sane person would define the version of the software depending on the compiler

Anyways, I have finally updated the pull request to limit it only to gcc and clang