prezto: ssh pass doesn't get saved, continues to prompt

Description

Recently pulled from master and updated, ssh-add no longer appears to run on my ssh ids

Expected behavior

my defined ssh-ids should be added

Actual behavior

I get prompted for every ssh action

Steps to Reproduce

If I revert ssh/init.zsh to this:

  if (( ${#_ssh_identities} > 0 )); then
	ssh-add "$_ssh_dir/${^_ssh_identities[@]}"  < /dev/null 2> /dev/null
  else
	ssh-add  < /dev/null 2> /dev/null
  fi

everything works as expected, or at least as it did before (I login to tty, I put my username/pass, and then am prompted for my ssh password)

I noticed this change: https://github.com/flying-sheep/prezto/commit/5a72d7c31f72c99c984964e65ec6d2471098d996

Am I supposed to define SSH_ASKPASS somewhere? I can’t use x11-ssh-askpass because I don’t have x11 loaded at this point in time (as I saw in the change before this one). I log in, and I run startx if I want to initiate an xsession. I’d like for my ssh-agent to behave regardless of environment.

Versions

  • Prezto commit: master branch
  • ZSH version: 5.4.2
  • OS information: Linux 4.13.7-1-ARCH

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 22 (6 by maintainers)

Commits related to this issue

Most upvoted comments

cool! maybe we should add a comment explaining that as well, before someone touches this piece of highly sensitive code.

Thank you for such a quick response, however it’s quite late here, I have replace the relevant line and will give feedback on login tomorrow