react-native-screens: [3.30.0] Installation fails after new release. `/bin/sh: 1: cd: can't cd to react-navigation`
Description
Hey guys. Just got this error from the CI/CD that was working fine previously:
error /project/node_modules/react-native-screens: Command failed.
Exit code: 2
Command: git submodule update --init --recursive && (cd react-navigation && yarn)
Arguments:
Directory: /project/node_modules/react-native-screens
Output:
/bin/sh: 1: cd: can't cd to react-navigation
I guess it’s because of the newest release and this PR? Didn’t really made much research and reproducing, but it seems quite clear what this is about
Steps to reproduce
yarn install react-native-screens- enjoy
Snack or a link to a repository
N/A
Screens version
3.30.0
React Native version
0.73.6
Platforms
Android, iOS
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Paper (Old Architecture)
Build type
None
Device
None
Device model
No response
Acknowledgements
Yes
About this issue
- Original URL
- State: closed
- Created 3 months ago
- Reactions: 3
- Comments: 19 (8 by maintainers)
That’s great to hear! Now I can sleep well 😄 🚀 I’ll assume this issue can be closed for now, but if anyone is still impacted of this error, feel free to comment your scenario below.
Cheers 🙏
Hi @kuzkokov, @donutdonate - thanks for reporting this. Yeah, looks like we didn’t cover
.gitmodulesfile we’ve added recently 😓 We’ll take care of this in upcoming days. ~For now, you can stay with the3.29.0version to build Screens on CI.~ If it’s possible for you, please wait up to 15-30 minutes for the new patch release. Thank you for your patience 🙏Thanks for the speedy fix @tboba
@tboba Just tested this now on 3.30.1 and it all seemed to work for me! Thanks for the speedy fix !
3.30.1 worked nice for me too 😃 Big thanks 👍
The patch has been released! Could you check whether this issue is fixed in
3.30.1?cc @kuzkokov @donutdonate @short-dsb @Alexandre-Cornillon @akeva001 @Lump01 @efstathiosntonas @twokilohertz @cubancodepath @mohd-ramzan-1
3.30.1worked as a charm, thank you @tboba for the really quick fix.I was able to install 3.30.1 successfully!
cc @aditya063 @FraserKemp (I see you’ve also reacted to the issue)
@efstathiosntonas okay, let me quickly check this change with
npm pack🙏About the offtopic - that’s because this nightly has been made for the purposes of making
goBackGesturework before the PR with implementing the functionalities on reanimated has been merged 😄