react-native-reanimated: [android][release] makeShareableCloneRecursive Call Stack Size Exceeded

Description

I’ll start by saying that I’ve spent many days on this and already looked at #4140, #4177, #4367 and #4475, and this is a separate issue. I also created an issue at expo/expo#23297 but I don’t think it’s expo’s fault because I could not reproduce this on their bare template. It’s worth noting that this does not occur on react-native@0.71 or expo@48.

The bug, for me, only occurs on the Android release build or the debug build with the JS Dev Mode disabled.

This gave me the idea to search for all __DEV__ flags within the installed version in my node_modules and flip all of them so that I can see the error in dev mode and get a nicer stacktrace. Here’s what I got:

This narrows down the problem quite well, and I found that the following patch solves my issue:

diff --git a/node_modules/react-native-reanimated/src/reanimated2/shareables.ts b/node_modules/react-native-reanimated/src/reanimated2/shareables.ts
index 4f358f4..8be3e2b 100644
--- a/node_modules/react-native-reanimated/src/reanimated2/shareables.ts
+++ b/node_modules/react-native-reanimated/src/reanimated2/shareables.ts
@@ -1,6 +1,6 @@
 import NativeReanimatedModule from './NativeReanimated';
-import { ShareableRef } from './commonTypes';
 import { shouldBeUseWeb } from './PlatformChecker';
+import { ShareableRef } from './commonTypes';
 import { registerWorkletStackDetails } from './errors';
 import { jsVersion } from './platform-specific/jsVersion';
 
@@ -146,8 +146,9 @@ export function makeShareableCloneRecursive<T>(
               value.__workletHash,
               value.__stackDetails
             );
-            delete value.__stackDetails;
           }
+          // TODO: This is the fixes Maximum call stack size exceeded error
+          delete value.__stackDetails;
           // to save on transferring static __initData field of worklet structure
           // we request shareable value to persist its UI counterpart. This means
           // that the __initData field that contains long strings represeting the

Obviously, this is not ideal and doesn’t seem like the official solution (why would stackDetails have anything to do with the fix?), so I’m hoping the team will have a better idea. Thanks for the great work!

Steps to reproduce

I could not reproduce this on the bare expo template, but I’m linking it anyway. I hope the patch I provided above will give some clue as to why it only happens on some projects.

1. Install react-native-reanimated@3.3.0
2. npx pod-install
3. Importing the library using import 'react-native-reanimated' in App.tsx is enough to trigger the bug

Snack or a link to a repository

https://github.com/thespacemanatee/expo-dev-menu-repro/tree/repro/reanimated-makeShareableCloneRecursive-crash

Reanimated version

3.3.0

React Native version

0.72.1

Platforms

Android

JavaScript runtime

Hermes

Workflow

Expo bare workflow

Architecture

Paper (Old Architecture)

Build type

Release mode

Device

Android emulator

Device model

Pixel 7 Pro (Android 13) and Pixel 3a (Android 10)

Acknowledgements

Yes