action-gh-release: v2.3.1 still broken: Assertion failed: !closed_
I see that the v2.3.1 release (just released not too long ago) was supposed to resolve #627 and #628 but it did not.
As seen below, it is clearly using softprops/action-gh-release/v2.3.1
# /Users/runner/runners/2.325.0/externals/node20/bin/node[2722]: MaybeLocal<Promise> node::fs::FileHandle::ClosePromise() at ../src/node_file.cc:457
# Assertion failed: !closed_
----- Native stack trace -----
1: 0x100708eb8 node::Assert(node::AssertionInfo const&) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
2: 0x101d6e0d0 node::fs::FileHandle::ClosePromise() (.cold.6) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
3: 0x10070dd2c node::fs::FileHandle::ClosePromise() [/Users/runner/runners/2.325.0/externals/node20/bin/node]
4: 0x10070dda8 node::fs::FileHandle::Close(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
5: 0x100939324 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, unsigned long*, int) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
6: 0x100938b74 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
7: 0x10124cb24 Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit [/Users/runner/runners/2.325.0/externals/node20/bin/node]
8: 0x1011c43e4 Builtins_InterpreterEntryTrampoline [/Users/runner/runners/2.325.0/externals/node20/bin/node]
9: 0x1011c4f44 Builtins_InterpreterEnterAtBytecode [/Users/runner/runners/2.325.0/externals/node20/bin/node]
10: 0x1011fb130 Builtins_AsyncFunctionAwaitRejectClosure [/Users/runner/runners/2.325.0/externals/node20/bin/node]
11: 0x1012a9118 Builtins_PromiseRejectReactionJob [/Users/runner/runners/2.325.0/externals/node20/bin/node]
12: 0x1011eacac Builtins_RunMicrotasks [/Users/runner/runners/2.325.0/externals/node20/bin/node]
13: 0x1011c23f4 Builtins_JSRunMicrotasksEntry [/Users/runner/runners/2.325.0/externals/node20/bin/node]
14: 0x100a3e748 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
15: 0x100a3f074 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
16: 0x100a3f260 v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
17: 0x100a69f50 v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
18: 0x100a6a6dc v8::internal::MicrotaskQueue::PerformCheckpoint(v8::Isolate*) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
19: 0x100620c84 node::InternalCallbackScope::Close() [/Users/runner/runners/2.325.0/externals/node20/bin/node]
20: 0x100620fb4 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
21: 0x1006[35](https://github.com/Geminus-AI/geminus-ai/actions/runs/15570885341/job/43846226158#step:10:36)2f0 node::AsyncWrap::MakeCallback(v8::Local<v8::Function>, int, v8::Local<v8::Value>*) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
22: 0x1006a93ac node::HandleWrap::OnClose(uv_handle_s*) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
23: 0x1011a4244 uv_run [/Users/runner/runners/2.325.0/externals/node20/bin/node]
24: 0x1006217e8 node::SpinEventLoopInternal(node::Environment*) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
25: 0x10074c48c node::NodeMainInstance::Run() [/Users/runner/runners/2.325.0/externals/node20/bin/node]
26: 0x1006cba78 node::Start(int, char**) [/Users/runner/runners/2.325.0/externals/node20/bin/node]
27: 0x18486f154 start [/usr/lib/dyld]
----- JavaScript stack trace -----
1: close (node:internal/fs/promises:250:23)
2: upload (/Users/runner/work/_actions/softprops/action-gh-release/v2.3.1/dist/index.js:16:16285)
About this issue
- Original URL
- State: closed
- Created a year ago
- Reactions: 5
- Comments: 15
Thanks for the bug reporting, let me take a look at it.
Hi all, just want to say thanks for quick resolution. Got hit by this yesterday and lo! itโs solved already ๐
should be fixed with v2 tag just now. (if not, feel free to throw another issue)
absolutely, :done:
Hey @chenrui333 thanks for your quick response on this issue. Would you be able to also update the
v2tag for this fix? Weโre still running into the issue with that version.Thanks again!
verified the fix via https://github.com/ruitest2/action-gh-release-test/actions/runs/15571581455/job/43848403236
Thank you @chenrui333 for your quick resolution on these issues!
Thanks @chenrui333!
Can also confirm that the
v2tag (2.3.2) is working as expected now. Thanks for the quick turnaround @chenrui333!i am having the same issue, thanks for the quick response ๐