sktime: [BUG] test failures in deep learning classifiers, regressors
Opening this issue to track known test failures with deep learning classifiers, regressors. Some of these seem to be due to interface or dependency degradation as tests were turned off.
Failures, with checkboxes (checked = fixed) and links to PR:
-
LSTMFCNRegressor- fails for multivariate output scenario after broadcasting -
LSTMFCNRegressor- fails duringbuild_networkwithx = AttentionLSTM(self.lstm_size)(x) -
MACNNClassifier,MACNNRegressor- fail all tests withValueError: A KerasTensor cannot be used as input to a TensorFlow function. -
SimpleRNNClassifier,SimpleRNNRegressor- fail all tests as passed argument islr, notlearning_rate, as the network expects - noticed by @vandit98 and fixed in https://github.com/sktime/sktime/pull/6154 -
ResNetClassifier,ResNetRegressorfail test case for serialization when attempting to pickle alambda -
test_deep_estimator_fullfails for regressors
Suggested procedure for debugging: pick one of these and ensure to run check_estimator locally until tests pass.
Test failures can be inspected here: https://github.com/sktime/sktime/pull/6138
About this issue
- Original URL
- State: open
- Created 3 years ago
- Comments: 15 (9 by maintainers)
Commits related to this issue
- [BUG] Resolved wrong arg name `lr` in `SimpleRNNClassifier` and regressor, fix minor `batch_size` param issue in `ResNetClassifier` (#6154) #### Reference Issues/PRs Fixes part of issue #6153 #... — committed to sktime/sktime by vandit98 3 years ago
- Resolve Issue #6153 — committed to ArthrowAbstract/sktime by ArthrowAbstract 3 years ago
- [BUG] Resolve `LSTMFCNClassifier` and `LSTMFCNRegressor` changing `callback` parameter (#6239) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: h... — committed to sktime/sktime by ArthrowAbstract 2 years ago
- [BUG] Resolve `LSTMFCNClassifier` and `LSTMFCNRegressor` changing `callback` parameter (#6239) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: h... — committed to geetu040/sktime by ArthrowAbstract 2 years ago
- Fixed [BUG]#6153 in MACNNClassifier,MACNNRegressor — committed to KrishBakshi/sktime by KrishBakshi 2 years ago
- Fixed [BUG]#6153 in MACNNClassifier,MACNNRegressor — committed to KrishBakshi/sktime by KrishBakshi 2 years ago
- Fixed[BUG]#6153 in MACNNClassifier,MACNNRegressor — committed to KrishBakshi/sktime by KrishBakshi 2 years ago
- [BUG] `AttentionLSTM` - Remove activity regularizers (#7582) #### Reference Issues/PRs Fixes #6685 Also relevant to #6153 (second issue) #### What does this implement/fix? Explain your changes. ... — committed to sktime/sktime by marcosfelt 2 years ago
- [BUG] fix bugs in `MACNNClassifier`, `MACNNRegressor` (#7651) #### Reference Issues/PRs Fixes part of issue #6153 #### What does this implement/fix? Explain your changes. MACNNClassifier, MACNNR... — committed to sktime/sktime by KrishBakshi 2 years ago
- [BUG] fix bugs in `MACNNClassifier`, `MACNNRegressor` (#7651) #### Reference Issues/PRs Fixes part of issue #6153 #### What does this implement/fix? Explain your changes. MACNNClassifier, MACNNR... — committed to sktime/sktime by KrishBakshi 2 years ago
- [BUG] `AttentionLSTM` - Remove activity regularizers (#7582) #### Reference Issues/PRs Fixes #6685 Also relevant to #6153 (second issue) #### What does this implement/fix? Explain your changes. ... — committed to ericjb/sktime by marcosfelt 2 years ago
- [BUG] fix bugs in `MACNNClassifier`, `MACNNRegressor` (#7651) #### Reference Issues/PRs Fixes part of issue #6153 #### What does this implement/fix? Explain your changes. MACNNClassifier, MACNNR... — committed to ericjb/sktime by KrishBakshi 2 years ago
- [BUG] `AttentionLSTM` - Remove activity regularizers (#7582) #### Reference Issues/PRs Fixes #6685 Also relevant to #6153 (second issue) #### What does this implement/fix? Explain your changes. ... — committed to sktime/sktime by marcosfelt 2 years ago
- [BUG] fix bugs in `MACNNClassifier`, `MACNNRegressor` (#7651) #### Reference Issues/PRs Fixes part of issue #6153 #### What does this implement/fix? Explain your changes. MACNNClassifier, MACNNR... — committed to sktime/sktime by KrishBakshi 2 years ago
Hi @fkiraly I have fixed the
MACNNClassifier,MACNNRegressor- fail all tests with ValueError: A KerasTensor cannot be used as input to a TensorFlow function. Please review it.Hi @fkiraly I just finished with
check_estimatorfor all listed, please find them below.LSTMFCNRegressor:
FAILED: test_multioutput[LSTMFCNRegressor-1]. MACNNClassifier:FAILED: test_classifier_on_unit_test_data[MACNNClassifier],FAILED: test_multioutput[MACNNClassifier-0],FAILED: test_multioutput[MACNNClassifier-1]. MACNNRegressor:FAILED: test_multioutput[MACNNRegressor-0],FAILED: test_multioutput[MACNNRegressor-1].SimpleRNNClassifier:All tests PASSED!SimpleRNNRegressor:All tests PASSED!ResNetClassifier:All tests PASSED!ResNetRegressor:All tests PASSED!currently working on resolving the multi-variate output issue
test_multioutput, please feel free to drop any guidelines/suggestions.Thanks for your response @fkiraly, I am looking into it!
hi @fkiraly I have opened a new pr for the fix. Please review it and let me know if it needs any changes.