sketch-module-web-view: Execute Javascript is throwing an error

After updating from 3.0.1 -> 3.0.7 I’m getting an error when calling executeJavascript. Looks like the issue disappears if I roll back to 3.0.2. 3.0.3+ doesn’t work.

Here is how I’m calling it, pretty basic:

window.webContents.executeJavaScript(script).catch(console.error);

Without changing anything except a different version 3.0.3+ of the web view, calling ☝️ now reaches an error on this line. Something with the state check:

    // if the webview is not ready yet, defer the execution until it is
    if (webview.navigationDelegate().state.wasReady == 0) {
      return new Promise(function(resolve, reject) {

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 17 (8 by maintainers)

Most upvoted comments

fixed in 3.2.0

window._panel.setHidesOnDeactivate(false); that’s good! I’m stealing it 😄