fake-timers: Safari test run breaks in Sauce Lab due to missing W3C WebDriver support

Full background: https://github.com/sinonjs/sinon/issues/2372.

Basically, Safari tests breaks with v12 and up. This needs to be fixed in min-wd (mantoni/min-webdriver#31).

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 21 (17 by maintainers)

Commits related to this issue

Most upvoted comments

I figured it out for this project and have a fix in https://github.com/mantoni/mochify.js/pull/244 (spoiler: there’s a very subtle bug in the geckodriver).

I’m happy to provide assistance for anyone who is willing to help. I’m sorry for the lack of documentation. A good way to start is to read through the initial “Mochify Rewrite” issue: https://github.com/mantoni/mochify.js/issues/229

Issues for the rewite can be found here: https://github.com/mantoni/mochify.js/milestone/1

Sounds great! I’ll wait for the PR. Thank you for being patient and helpful about all of it.

Thanks for looking into it. There is clearly not enough documentation yet. I managed to run tests by invoking the new Mochify CLI locally using a relative path.

However, I will make a 0.1.0 release this afternoon and send a PR here. We can then iterate on that together. It’s a lot easier when we have a running example to talk about.

I’m actually working on a Mochify rewrite (https://github.com/mantoni/mochify.js has a rewrite branch), and the current state seems to work fine. I just don’t have enough free time to get it across the finish line.

Great, @itayperry is this something you’d be interested in contributing? It could be a good chance to contribute to another project too (WebdriverIO)

Yes it could. Then easiest would be to implement a browserify plugin compatible interface into webdriverio similar as min-wd does it.