TileDB-SOMA: [Bug] I cannot build package from source with the latest release
Describe the bug
I download the repository to my local, switch to the latest version 1.9.4, and then run make r-build. However, it failed. I was able to run make r-build for version 1.9.3 in the same environment.
The errors I got are as follow
[ 24%] Building CXX object _deps/catch2-build/src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_event_listener.cpp.o /home/tiledbsoma/TileDB-SOMA/libtiledbsoma/src/utils/nanoarrow.c: In function ‘int64_t ArrowSchemaToString(const ArrowSchema*, char*, int64_t, char)’: /home/tiledbsoma/TileDB-SOMA/libtiledbsoma/src/utils/nanoarrow.c:1779:28: error: null destination pointer [-Werror=format-truncation=] n_chars_last = snprintf(out, n, “>”);
~~~~ [ 24%] Building CXX object _deps/catch2-build/src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_helpers.cpp.o cc1plus: all warnings being treated as errors gmake[6]: *** [src/CMakeFiles/TILEDB_SOMA_OBJECTS.dir/build.make:342: src/CMakeFiles/TILEDB_SOMA_OBJECTS.dir/utils/nanoarrow.c.o] Error 1 gmake[6]: *** Waiting for unfinished jobs…^// skip some logs in between
pp.o gmake[5]: *** [CMakeFiles/Makefile2:156: src/CMakeFiles/TILEDB_SOMA_OBJECTS.dir/all] Error 2 gmake[5]: *** Waiting for unfinished jobs… [ 88%] Linking CXX static library libCatch2.a [ 88%] Built target Catch2 gmake[4]: *** [Makefile:146: all] Error 2 gmake[3]: *** [CMakeFiles/libtiledbsoma.dir/build.make:86: libtiledbsoma-prefix/src/libtiledbsoma-stamp/libtiledbsoma-build] Error 2 gmake[2]: *** [CMakeFiles/Makefile2:113: CMakeFiles/libtiledbsoma.dir/all] Error 2 gmake[1]: *** [Makefile:91: all] Error 2 make: *** [Makefile:21: r-build] Error 2
It seems like the same file is changed by most recent commit and this commit failed TileDB-R-CI. Any advice of how to fix this would be pretty helpful.
To Reproduce
Download repository
switch to 1.9.4
run make r-build
Versions (please complete the following information):
- TileDB-SOMA version: 1.9.4
- Language and language version (e.g. Python 3.8, R 4.2.2): R version 4.3.2
- OS (e.g. MacOS, Ubuntu Linux): Centos stream 8
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 21 (12 by maintainers)
Thank you! I believe it is working. I will do some more tests next week.
I am installing this in docker and if you are planning to test on centos 8, there is one thing to note that gcc 8.5 is missing
filesystemlibrary and need to add-lstdc++fsflag to cmake files. If you use gcc 9, then no need to worry about it.#2408 I believe will address all remaining concerns – closing this issue – please let me know if I’m mistaken and we can reopen – thank you!
OK @angela18199 thank you! At the end of the output there is the line (line breaks added by me for clarity)
which shows that
-Werroris still making it tonanarrow.c.I’ll circle back & come back with an update on the advice on how to avoid
-Werroron this file.I make sure
extra_opts="-DTILEDBSOMA_ENABLE_WERROR=OFF -DTILEDB_WERROR=OFF"cmake debug is set to true runmake r-buildHere is the logThanks!
@angela18199 thank you! Can you share your
/usr/bin/c++ --version? Or-versionas the case may be?Here is the full log
Also regarding
In fact fixed the compile error for us. We have redundant CI – pre-commit, post-commit, and version-tag. Earlier today I cancelled some redundant CI jobs to make room for others, in cases when they were redundant. The red CI you saw above was due not to a fail but a cancellation. To avoid any confusion I’ve restarted all the cancelled jobs at https://github.com/single-cell-data/TileDB-SOMA/pull/2398/checks. These are now all green. My apologies for any confusion caused here.
Operation system is CentOS Stream release 8