got: Broken with Node.js ≥ 13.10.0

Describe the bug

Node.js version: 13.10.0 or 13.10.1
OS & version: Linux 5.5.6-1-MANJARO x86_64 GNU/Linux

got.stream does not work with Node.js ≥ 13.10.0. Node.js 13.9.0 works fine.

Actual behavior

When piped into a stream, the receiving stream receives no data.

Expected behavior

When piped into a stream, the receiving stream receives the entire HTTP response.

Code to reproduce

const got = require("got");
got.stream("https://www.github.com/").pipe(process.stdout);
// one can also use stream.pipeline here. Same result.

With Node.js < 13.9.0, output fills the screen. With ≥ 13.10.0, there is no console output.

Checklist

I have read the documentation.
I have tried my code with the latest version of Node.js and Got.

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 13
Comments: 19

Most upvoted comments

Same behavior here but all got is affected not only streams :

const got = require("got");

// ensure no exit before the timer was cleared
const interval = setInterval(() => {}, 60000);

(async () => {
	console.log('step 1');
	const result = await got("https://www.github.com/");
	console.log(result);
	console.log('step 2');
	clearInterval(interval);
})();

This code never throws, exits or output results. It only display step 1 and do nothing more. Before node 13.10.0 it displays results.

darksabrefr on Mar 5, 2020

2 hours of debugging and searching for my mistake… 😄 Same here after upgrading Node to v13.10.1.

mrGibi on Mar 5, 2020

It’s the first time I use this library, I haven’t used nodejs for a long time so it took me a long time to even get here, not to mention that I did not read got’s source code… I’m using node v13.11.0 and the bug is still there for me. How can this happen on an LTS release? This is my code:
async function() {
 try {
  const response = await got.post(API_URI + '/Account/token');
  console.log("hello"); //never reached
 }
 catch (e) {
    // never reached
 }
}
Is there any workaround?

Can you provide a reproducible example ? Your use case is too imprecise. I use got and node (v13.11.0) intensively and I have no problem other than https://github.com/sindresorhus/got/issues/1096 which is not node version related and is similar to yours.

darksabrefr on Mar 23, 2020

Nose.js v13.x is not an LTS branch.

TimothyGu on Mar 23, 2020

Updating to Node.js v13.11.0 has fixed the issue for me!

Pytal on Mar 12, 2020

LOL @nodejs messed up!

const {PassThrough, pipeline} = require('stream');
const https = require('https');

const body = new PassThrough();
const request = https.request('https://example.com');

request.once('abort', () => {
	console.log('The request has been aborted');
});

pipeline(
	body,
	request,
	error => {
		console.log(`Pipeline errored: ${!!error}`);
	}
);

body.end();

gives

Pipeline errored: false
The request has been aborted

This is the culprit: https://github.com/nodejs/node/pull/31940/files#diff-eefad5e8051f1634964a3847b691ff84R36

It calls .abort() on every request you make using pipeline.

https://github.com/nxtedition/node/blob/5a55b1df97a1f93c5fb81bf758050d81524ae834/lib/internal/streams/destroy.js#L166

szmarczak on Mar 5, 2020

It’s gonna be a patch release. I’m working on this right now.

szmarczak on Mar 5, 2020

As of Node.js v13.11.0 and 48b817e all tests pass 😄

szmarczak on Apr 12, 2020

I am sure. I see you haven’t looked at Got source code. Few people do.

szmarczak on Mar 5, 2020