prettier-plugin-organize-imports: Does not work with pug templates via VS Code Prettier plugin

Now #78 is solved and prettier --write . works… But when I run format on save via VSCode it is the same behavior as before #78 got fixed 🤔

But now I’m not sure if this has something todo with your plugin or if esbenp.prettier-vscode has a bug. I highly assume it has still something todo with the vueCompilerOptions not forwarded correctly.

/ping @johnsoncodehk

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 27 (14 by maintainers)

Commits related to this issue

fix: LS host's `getCurrentDirectory` implementation returns project root based on tsconfig location Fixes #84. — committed to simonhaenisch/prettier-plugin-organize-imports by simonhaenisch 2 years ago
fix: LS host's `getCurrentDirectory` implementation returns project root based on tsconfig location Fixes #84. — committed to simonhaenisch/prettier-plugin-organize-imports by simonhaenisch 2 years ago

Most upvoted comments

@Shinigami92 finally got around to finish this, should work in 3.2.1 crossed_fingers

Thanks, might be that I can test it first on monday

Shinigami92 on Nov 25, 2022

Update: yeah ok this seems to make it work:

getCurrentDirectory() {
  return path.dirname(tsconfig)
}

@johnsoncodehk would be nice if you could confirm that it’s a good fix? (I’d only add this to the Vue language service host)

simonhaenisch on Nov 14, 2022

@simonhaenisch Works 🙆

Shinigami92 on Nov 28, 2022

@Shinigami92 finally got around to finish this, should work in 3.2.1 🤞

simonhaenisch on Nov 25, 2022

Sorry I was sick, will need a bit longer for this one.

Get well soon, I depend on you ^^

Shinigami92 on Nov 24, 2022

Sorry I was sick, will need a bit longer for this one.

simonhaenisch on Nov 24, 2022

Ok then I guess I’ll implement this as a fix and hope it doesn’t backfire 🤞😅 Might take a couple days though.

simonhaenisch on Nov 15, 2022

Can you try logging rootDir

@johnsoncodehk I get "/".

Edit: hard-coding it to the project’s path fixes it (module not found error gone, and formatting works as expected). I have no idea why the Prettier extension runs prettier from the root directory and not the current VS Code project root 🤷🏻‍♂️ Maybe it’s a bug that should be raised with the extension… at least this behavior doesn’t make any sense to me.

simonhaenisch on Nov 14, 2022

So, it finds the tsconfig and Vue compiler options just fine, however Volar (more specifically, @volar/vue-language-core, which is used by @volar/vue-typescript, which is is used by this plugin to create the language service) fails to load the pug language plugin:

[Extension Host] Load plugin failed @volar/vue-language-plugin-pug Error: Cannot find module '@volar/vue-language-plugin-pug'
Require stack:
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/@volar/vue-language-core/out/plugins.js
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/@volar/vue-language-core/out/languageModule.js
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/@volar/vue-language-core/out/index.js
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/@volar/vue-typescript/out/index.js
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier-plugin-organize-imports/lib/get-language-service.js
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier-plugin-organize-imports/lib/organize.js
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier-plugin-organize-imports/index.js
- /path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier/index.js
- /user-dir/.vscode/extensions/esbenp.prettier-vscode-9.9.0/dist/extension.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:987:15)
    at Function.p.resolve (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:761)
    at getDefaultVueLanguagePlugins (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/@volar/vue-language-core/out/plugins.js:33:44)
    at Object.createLanguageModule (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/@volar/vue-language-core/out/languageModule.js:10:74)
    at Object.createLanguageService (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/@volar/vue-typescript/out/index.js:6:23)
    at getLanguageService (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier-plugin-organize-imports/lib/get-language-service.js:14:43)
    at module.exports.organize (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier-plugin-organize-imports/lib/organize.js:26:26)
    at organizeImports (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier-plugin-organize-imports/index.js:19:10)
    at Object.preprocess (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier-plugin-organize-imports/index.js:42:4)
    at Object.parse (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier/index.js:7330:25)
    at coreFormat (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier/index.js:8645:18)
    at formatWithCursor2 (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier/index.js:8837:18)
    at /path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier/index.js:37229:12
    at Object.format (/path/to/prettier-plugin-organize-imports-issue-78/node_modules/prettier/index.js:37243:12)
    at t.default.format (/user-dir/.vscode/extensions/esbenp.prettier-vscode-9.9.0/dist/extension.js:1:14565)
    at t.PrettierEditProvider.provideEdits (/user-dir/.vscode/extensions/esbenp.prettier-vscode-9.9.0/dist/extension.js:1:11259)
    at B.provideDocumentFormattingEdits (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:45902)

Not sure why this happens, all the paths look kinda ok, and I double-checked that @volar/vue-language-plugin-pug exists in node_modules 🤷🏻‍♂️ Maybe @johnsoncodehk has an idea…

simonhaenisch on Nov 14, 2022

Ok can reproduce, and the first difference I can tell (from logging some stuff into VS Code developer tools) is that when run from the CLI, it runs in the path relative to the project, whereas the VS Code Prettier extension runs the project from the system root (i.e. process.cwd() gives /) 😳 That might cause an issue with finding the tsconfig but i’ll dig some deeper to narrow it down.

simonhaenisch on Nov 14, 2022