silverstripe-framework: Centered image alignment crashes on save
In a HTMLEditorField
, selecting Centered, on its own.
for an image’s alignment causes the following fatal PHP error on save:
PHP Fatal error: Call to a member function appendChild() on null in /Volumes/Users/foo/Sites/bar/framework/View/Parsers/ShortcodeParser.php on line 187
All other alignments seem to save ok.
Observed in the latest dev-master.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 33 (25 by maintainers)
Commits related to this issue
- BUG Temp disable shortcode SPLIT behaviour due to crash Fixes #5987 — committed to open-sausages/silverstripe-framework by deleted user 8 years ago
- BUG Temp disable shortcode SPLIT behaviour due to crash (#6436) Fixes #5987 — committed to silverstripe/silverstripe-framework by deleted user 8 years ago
- BUG Temp disable shortcode SPLIT behaviour due to crash (#6436) Fixes #5987 — committed to silverstripe/silverstripe-framework by deleted user 8 years ago
Hi everyone, I’m the author of mentioned Shortcode library. I’d like to address some of the concerns raised here and in #5535. I’ll link the comments and answer them here:
ProcessorInterface
compliant processor, that’s exactly the reason I made the library so extensible,1.0.0
release. As for the<p>
tag issue, please see my recent answer https://github.com/thunderer/Shortcode/issues/40#issuecomment-257632082 ,I’d throw my weight behind @thunderer’s package. It can’t be worse than writing our own and there’s nothing stopping us forking it if things go bad with it in the long term (no offence). If that happens we’re just in the same place we are now, maintaining a shortcode parser.
Maybe if @thunderer was happy to recruit some more contributors it could alleviate our worries?