silverstripe-elemental: Sorting blocks in draft mode can cause changes on the frontend as it updates the Element_Live table sort value
Module version(s) affected
4.11.0
Description
When re-order the blocks without publishing the page, I would expect no changes to the frontend. So I looked into the sort values in the database and finds out that sorting blocks in draft mode also updates the Element_Live table.
How to reproduce
I have created some dummie data to re-create the bug, before re-ordering
Both Element & Element_Live table look like this
the following data is after moving content block 8,9,10 up below content block 1.
The Element table
Select `ID`, `Title`, `Sort` FROM `Element` ORDER BY `Sort` ASC;
The Element_Live table
Select `ID`, `Title`, `Sort` FROM `Element_Live` ORDER BY `Sort` ASC;
On the front-end, the content block 7 is under content block 10, because they both have the same sort value on the Element_Live table, the next thing it sorts by if they both have the same sort value is the ID, in this case content block 7 has a higher ID than content block 10.
Possible Solution
No response
Additional Context
No response
Validations
- Check that there isn’t already an issue that reports the same bug
- Double check that your reproduction steps work in a fresh installation of
silverstripe/installer(with any code examples you’ve provided)
Acceptance criteria
- First validate if the sort order goes straight to live in symbiote gridfieldextensions
- (assuming it doesn’t) remove the straight to live logic in CMS 5.3
PRs
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 15 (14 by maintainers)
I’ve had a look around at the history of “why” things are like this - the issue is here (as a comment on a related though slightly different original issue) - the code went in this pr and a link was made on that PR to a long research/discussion piece No clear way to handle sorting with versioned object
At the end of that long piece there a Ingo commented that it was “… a long standing issue, which can be remedied from an author perspective by simply publishing everything …”
After all of that I’m still not quite sure why in elemental it’s is directly updating the _Live table though. I don’t think that should be happening.
There was a comment on the PR “Note this functionality is similar to SiteTree in CMS but is still inherently flawed” - that’s now false, I did a quick test reordering the main tree in the CMS that list pages and the _Live table is not updated, on draft. So we should update elemental to match that behaviour.
I’m not sure that an RFC is really something needed here. Draft changes are going straight to live on a versioned dataobject without the user first clicking a publish button.
I think it’s fair to assume that content editors would find this to be an unexpected behaviour
I think should just be treated as a regular bug.
@Jianbinzhu Please test https://github.com/silverstripe/silverstripe-elemental/pull/1234 and see if it fits your needs
@GuySartorelli in general, do we need to consider there might be potentially other changes to the sibling records that we don’t want written/published and where a low-level SQL update would be better? That could be the reason why SiteTree does it that way and would be probably also what I would prefer, unless we had a mechanism where we could tell
writeorpublishto only look at certain fields and leave others untouched.EDIT: Never mind, checked the PR and it’s done via the SQL update, so that’s all good.
Linked PRs have been merged, they will be released in CMS 5.3
@GuySartorelli this is working like a gem 😁
Yeah those are the lines writing to the live table on a draft save.
I’d expect that you’d simply reduce it to
$tableNames = [$baseTableName];.Yeah, that’ll happen because only blocks that have modified changes will be published. I think the ReorderElements doesn’t actually write new versions, instead it just updates the Sort column directly. I think you’d need to make other changes to the elements so that they get published on page save so that the new Sort order goes live
You could probably make a case that all the blocks that get their Sort order updated by ReorderElements should just get the regular ORM
$block->write()treatment on sort so they all get new versions. That should ensure that page publishing works as expected.@Jianbinzhu The issue is located in
ReorderElements:Looks like this behaviour is intentional although I can’t really understand why. Either way you should be able to use Injector to override this class and disable this behaviour so you can at least fix this on your project.
@Jianbinzhu
Managed to reproduce this issue as well. Here are the details I’ve found (tested on
4.13.44of the CMS):It looks like the reorder auto-publishes the changes on alll other blocks that were impacted by the block reorder except the one block that was moved around.
This is how it looks like after reorder:
Note the red circle on the Block 2 which was dragged down. It’s in modified on draft stage while the other block reports published.
Draft table data looks ok.
Live table data is incorrect as we have a mix of data present (one block was published and the other was not).
The data gets corrected after publishing the page though.
I have just replicate this issue on
silverstripe-framework: 5.2.8andsilverstripe-element: 5.2.3