shopify-api-ruby: Breaking change notice for version 10.0.0 GREATLY underrepresented

Overview/summary

I have been working through an enormous amount of bugs and issues from upgrading past 10.0.0 that the readme didn’t come close to preparing me for.

The old activeresource connections between things (like order.transactions) made navigating between data models easy. This is removed in almost every case (but not all like order.customer, which is also confusing). It doesn’t error, it just returns nil like every other undefined method. order.asdf should error but it doesn’t. There’s no way to differential nil values from missing methods.

Many values are now hashes instead of structs— You can’t access the values in the same way. For example order.note_attributes is now a hash, so any iteration over them fails.

This has been a REALLY time-consuming and error prone upgrade.

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Reactions: 17
  • Comments: 15 (3 by maintainers)

Most upvoted comments

I believe issues should be marked as stale, only if the last person who contributed is part of the Shopify team.

#truth

Imagine the development cost being needlessly foisted on companies using this gem for breaking changes that don’t add much (if any) value to the consumers.

FWIW, we’ve decided to just use HTTParty directly to the REST API rather than migrate to v10+ of this gem.

NOT STALE

Closing this ticket now that there are improvements made to the docs. Feel free to open other tickets for specific issues you encounter and we’ll try our best to answer your questions. Thanks everyone!

Writing an upgrade doc from v9 is on our roadmap for the next 6 week cycle. We agree, we definitely need a better guide for upgrading.

I am having trouble with the update to version 10 as it has affected all REST and GraphQL requests. The readme is not useful as it does not provide enough information on the breaking changes.

The lack of any response is certainly getting stale.