shipit-engine: Redirect URI Mismatch

Hi! I’m using Github enterprise, and have attempted to set up ShipIt and am having a problem with the authentication. I’m this is amazon with an ELB (port 443) -> Target Group (443 translates to 80) -> Instance (running rails on port 80)

When I attempt to go to the main page, I get the following URL (which translates to a 404 in rails)

https://shipit.xxxx.com/auth/failure?message=redirect_uri_mismatch&origin=https%3A%2F%2Fshipit.xxxx.com%2F&strategy=github

When I do a TCPDump on the EC2 instance, I see the following:

        HTTP/1.1 302 Found
        Location: https://github.xxxx.net/login/oauth/authorize?client_id=MY_CUSTOM_ID&redirect_uri=https%3A%2F%2Fshipit.xxxx.com%2Fgithub%2Fauth%2Fgithub%2Fcallback%3Forigin%3Dhttps%253A%252F%252Fshipit.xxxx.com%252F&response_type=code&scope=email%2Crepo_deployment&state=114a72085634e402687c92367a5ab431dd09261ae3c3422b
        Cache-Control: no-cache
        Set-Cookie: _shipit_session=VERY_LARGE_COOKIE; path=/; secure; HttpOnly
        X-Request-Id: 0088f92e-9e8b-4f92-b4d8-7b00ad3eec88
        X-Runtime: 0.002006
        Strict-Transport-Security: max-age=15552000; includeSubDomains
        Content-Length: 348

        Redirecting to https://github.xxxx.net/login/oauth/authorize?client_id=MY_CUSTOM_ID&redirect_uri=https%3A%2F%2Fshipit.xxxx.com%2Fgithub%2Fauth%2Fgithub%2Fcallback%3Forigin%3Dhttps%253A%252F%252Fshipit.xxxx.com%252F&response_type=code&scope=email%2Crepo_deployment&state=114a72085634e402687c92367a5ab431dd0926[!http]

My Github App is configured with User Authorization Callback URL as:

https://shipit.xxxx.com/github/auth/github/callback

Out of an abundance of caution, I’m also running force_ssl = True (since that was hinted at in #684).

At this point I’m at a loss of what I’m doing wrong, when I decode the TCPDump the RedirectURI matches that of what’s in the github app.

Thanks for your help.

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 16 (7 by maintainers)

Most upvoted comments

Sorry I couldn’t help you more.