ruby-lsp-rails: CI is marking failed Windows tests as passing

Originally posted in https://github.com/Shopify/ruby-lsp-rails/pull/350

Note: There are some green checks even though I’m pretty sure they should fail. I think tests doesn’t run on windows right now because of how it is invoked in the workflow. It probably chokes on the &&.

https://github.com/Shopify/ruby-lsp-rails/actions/runs/8821159752

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 16 (13 by maintainers)

Most upvoted comments

@mohits I’ve replied on the issue.

Right, but it may be worth a mention in other places, e.g. https://guides.rubyonrails.org/command_line.html#command-line-basics

@mohits thanks, I suspect that may need a fix in Rails, I’ve let @koic know here.

I remember this recent rails issue about the rubocop binstub not working on windows: https://github.com/rails/rails/issues/51618

Maybe bundle binstubs rails --force produces a meaningful result? Would probably need to be run on a windows machine, now that I think about it…