react-native-skia: [iOS] Image re-rendering with potential memory leak
Description
I am trying to build a pdf document viewer using react native skia and reanimated. This requires rendering bitmap tiles of a pdf page at different resolution levels when we peform pinch zoom on canvas. As a result of that, I have to regenerat the Skia Image multiple times and assign to the same image component. Please have a look at following simplified code sample. The issue I am struggling is, when I zoom in and generate images of 3000 x 3000 pixels, memory usage goes up as expected but when I zoom out and generate 300x300 bitmaps, memory does not go back down. I initially though that this is related to delayed garbage collection but it seems like not the case as the memory is occupied permanantly for a long period of time. I lookd at the memory profile and there is a lot of objects with stuck at SkData::MakeWithCopy and I think those are the images I created on demad when the pinch zoom ended. Can you help me to figure out why this memory leak is happening and what could be the potential resolution for this?
import React, { useEffect, useState } from 'react';
import { View, StyleSheet } from 'react-native';
import { Canvas, Skia, AlphaType, ColorType, Fill, Image, SkImage } from '@shopify/react-native-skia';
import { GestureDetector, Gesture, GestureHandlerRootView } from 'react-native-gesture-handler';
import Animated, {
useSharedValue,
useDerivedValue,
runOnJS,
} from 'react-native-reanimated';
function App(): React.JSX.Element {
const tileSize = 512;
const scale = useSharedValue(1);
const translationX = useSharedValue(0);
const translationY = useSharedValue(0);
const [scaleEnd, setScaleEnd] = useState(1);
const [skiaImage, setSkiaImage] = useState<SkImage>();
const createTile = (tileSize: number) => {
const pixels = new Uint8Array(tileSize * tileSize * 4);
pixels.fill(255);
let i = 0;
for (let x = 0; x < tileSize; x++) {
for (let y = 0; y < tileSize; y++) {
pixels[i++] = (x * y) % 255;
}
}
const data = Skia.Data.fromBytes(pixels);
const img = Skia.Image.MakeImage(
{
width: tileSize,
height: tileSize,
alphaType: AlphaType.Opaque,
colorType: ColorType.RGBA_8888,
},
data,
tileSize * 4
);
return img;
}
if (skiaImage === null) {
return <View style={styles.container} />;
}
const panGesture = Gesture.Pan().onChange((e) => {
translationX.value += e.changeX;
translationY.value += e.changeY;
});
const scaleGesture = Gesture.Pinch().onChange((e) => {
scale.value += e.scaleChange - 1;
}).onEnd(() => {
runOnJS(() => {
setScaleEnd(scale.value);
})();
}).runOnJS(true);
useEffect(() => {
const skImg = createTile(tileSize * scale.value);
console.log("Skia image calculating for tile size " + tileSize * scale.value);
if (skImg !== null) {
setSkiaImage(skImg);
}
}, [scaleEnd]);
return (
<GestureHandlerRootView>
<View style={{ flex: 1 }}>
<Canvas style={{ flex: 1 }}>
<Fill color="pink" />
<Image image={skiaImage} x={translationX} y={translationY} width={useDerivedValue(() => tileSize * scale.value)} height={useDerivedValue(() => tileSize * scale.value)} />
</Canvas>
<GestureDetector gesture={Gesture.Race(panGesture, scaleGesture)}>
<Animated.View style={StyleSheet.absoluteFill} />
</GestureDetector>
</View>
</GestureHandlerRootView>
);
};
const styles = StyleSheet.create({
container: {
flex: 1,
backgroundColor: "pink",
},
canvasContainer: {
flex: 1,
justifyContent: "center",
alignItems: "center",
},
canvas: {
flex: 1,
},
animatedCanvas: {
flex: 1,
},
});
export default App;
React Native Skia Version
1.9.0
React Native Version
0.76.5
Using New Architecture
- Enabled
Steps to Reproduce
Run the attached code and try multiple pinch zoom on iOS
Snack, Code Example, Screenshot, or Link to Repository
About this issue
- Original URL
- State: open
- Created 2 years ago
- Comments: 21 (8 by maintainers)
Thank you for looking into this deeper, I definitely want to consolidate the situation there.
I seem to have memory leak issues with skia as well lately. Can’t tell if it’s related at all, not sure how I can debug this. When I activate skiaFrameProcessor, you can see the memory going up until app crashes. video
all the flag does is activate
where: const defaultPaint = Skia.Paint()
Update: Able to fix the issue be downgrading version of: skia from 1.11.5 -> 1.10.2 worklet-core from 1.5.0 -> 1.3.3
@DImuthuUpe any chance you could update your example at the top of the issue to use .dipose (with the crash, and then I can investigate it?)
On Thu, Feb 6, 2025 at 2:05 PM Ronald Goedeke @.***> wrote:
Currently we are not using setExternalMemory pressure from Hermes and therefore this skiaImage gets garbage collected eventually but at a much later time than expected. calling skiaImage.dispose() when setting a new image should help. I would be curious to see the behavior you are experiencing. In my case we can log that all objects are properly deleted from the garbage collector but I still see a very high memory pressure, not sure why. I asked the questions on the hermes github: https://github.com/facebook/hermes/issues/1518
On Thu, Jan 23, 2025 at 3:22 PM Dimuthu Wannipurage @.***> wrote: