cli: `theme pull` in a non-empty and non-theme directory hangs on CI environment (even with `SHOPIFY_CLI_TTY`)
Please confirm that you have:
- Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
- Reproduced the issue in the latest CLI version.
In which of these areas are you experiencing a problem?
Theme
Expected behavior
shopify theme pull
being run in a non-theme directory and in an CI/CD environment (→ docs) should display confirmation dialogue It doesn’t seem like you’re running this command in a theme directory. Are you sure you want to proceed? and not hang if SHOPIFY_CLI_TTY
is set to 0
.
Actual behavior
theme pull
hangs, never completes, and displays no further message.
Stack trace
[STARTED] Installing theme dependencies
2023-01-18T11:19:35.391Z:
Running system process:
· Command: ruby -v
· Working directory: /home/runner/work/shopify-theme/shopify-theme
2023-01-18T11:19:35.417Z:
Running system process:
· Command: bundle -v
· Working directory: /home/runner/work/shopify-theme/shopify-
…
2023-01-18T11:19:35.747Z:
Running system process:
· Command: bundle install
· Working directory: /home/runner/.cache/shopify-cli-nodejs/vendor/ruby-cli/2.34.0
[SUCCESS] Installing theme dependencies
2023-01-18T11:19:48.295Z:
Running system process:
· Command: bundle exec shopify theme pull /home/runner/work/shopify-theme/shopify-theme --theme 140280135974
· Working directory: /home/runner/work/shopify-theme/shopify-theme
Reproduction steps
Create a github actions file with following settings
name: Theme deploy
on: [push]
jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v3
with:
node-version: 18
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.1
bundler: 'latest'
- name: Install Shopify CLI
run: npm install -g @shopify/cli @shopify/theme
- name: Deploy
env:
# Store URL, like your-store.myshopify.com
SHOPIFY_FLAG_STORE: '${{ secrets.SHOPIFY_STORE }}'
# Password generated from Theme Access app
SHOPIFY_CLI_THEME_TOKEN: ${{ secrets.SHOPIFY_CLI_THEME_TOKEN }}
SHOPIFY_CLI_TTY: 0
run: shopify theme push --path ./path/to/your/theme --theme your-theme-name-or-id
Populate the secrets and attempt to deploy
Operating System
Github Actions
Shopify CLI version (check your project’s package.json
if you’re not sure)
3.34
Shell
No response
Node version (run node -v
if you’re not sure)
No response
What language and version are you using in your application?
No response
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 20 (9 by maintainers)
@Poitrin
Scratch that, I just copied your snippet exactly (apart from the secrets): https://github.com/satori-berlin/shopify-theme/blob/main/.github/workflows/dep2.yaml -> It still fails