cli: [Bug]: CLI not killing old processes
Please confirm that you have:
- Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
- Reproduced the issue in the latest CLI version.
In which of these areas are you experiencing a problem?
App
Expected behavior
I have reason to believe v3 of the cli is not killing old processes. Please see this issue for a complete breakdown, putting this here because initially I thought it was an issue with the express boiler, but after further testing revealed it is a bug in the cli.
Actual behavior
Stack trace
No response
Reproduction steps
Operating System
Windows 10
Shopify CLI version (check your project’s package.json if you’re not sure)
3.17.0
Shell
No response
Node version (run node -v if you’re not sure)
No response
What language and version are you using in your application?
No response
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 1
- Comments: 16 (4 by maintainers)
@Michael-Gibbons I’ve narrowed down this to a Windows only issue. I’ve opened a draft PR that seems to do the trick. If we can confirm that this fixes the issue we’ll merge and release!
@matteodepalo I haven’t looked into the issue as much as @Michael-Gibbons did, but I can confirm the issue still persists on Windows. I have to run
taskkill /f /im node.exeevery time I stop my server that was running withyarn shopify app devExperiencing the same today on windows. Tried manually running
yarn devand on server shut down the processes are correctly killed. But when using the CLI I get a bunch ofnode.exeandcmd.exeprocesses that block me from deleting and moving files, as they are still being used by the zombie processes.