cli: [Bug]: 3.58.0 in Github Action is not pushing files
Please confirm that you have:
- Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
- Reproduced the issue in the latest CLI version.
In which of these areas are you experiencing a problem?
Theme
Expected behavior
Files should be uploaded as before
Actual behavior
Files are not uploaded, command says it was successful.
Verbose output
##[debug]Evaluating: secrets.SHOPIFY_FLAG_STORE
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'SHOPIFY_FLAG_STORE'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Evaluating: secrets.SHOPIFY_CLI_THEME_TOKEN
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'SHOPIFY_CLI_THEME_TOKEN'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Evaluating condition for step: 'Deploy only build to live theme'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Deploy only build to live theme
##[debug]Loading inputs
##[debug]Loading env
Run shopify theme push -o 'assets/components-legacy.bundle.js' -o 'assets/components.bundle.js' -o 'assets/checkout-legacy.bundle.js' -o 'assets/checkout.bundle.js' -o 'assets/index.css' -l -a --verbose
##[debug]/usr/bin/bash -e /home/runner/work/_temp/63b61558-7e3f-4651-8fdf-2fef4a7ce3ae.sh
2024-03-28T15:02:05.396Z: Running command theme push
2024-03-28T15:02:05.437Z: Ensuring that the user is authenticated with the Theme API with the following scopes:
[]
2024-03-28T15:02:05.449Z: Getting development theme...
2024-03-28T15:02:06.209Z: Request to https://theme-kit-access.shopifyapps.com/cli/admin/api/unstable/themes.json?fields=id%2Cname%2Crole%2Cprocessing completed in 748 ms
With response headers:
- cache-control: max-age=0, private, must-revalidate
- content-type: application/json; charset=utf-8
- etag: W/"05d6b66e5a537606b8b9fb046140a78b"
- x-request-id: 9e7a4394-afad-44b1-91fb-ec7eba102caf-1711638125
2024-03-28T15:02:07.526Z: Request to https://theme-kit-access.shopifyapps.com/cli/admin/api/unstable/themes/159602639172/assets.json?fields=key%2Cchecksum completed in 1262 ms
With response headers:
- cache-control: max-age=0, private, must-revalidate
- content-type: application/json; charset=utf-8
- etag: W/"3408448d30bd419a80e203a2157fb152"
- x-request-id: 6cedbb41-5275-4d36-9b5a-c618f649aba9-1711638126
2024-03-28T15:02:07.570Z: Reading the content of file at assets/Mail.jpg...
[...]
2024-03-28T15:02:08.080Z: Ignoring theme file assets/ajax-loader.gif via --only...
[...]
2024-03-28T15:02:08.475Z: Files to be uploaded:
-assets/index.css
2024-03-28T15:02:08.476Z: Reading theme files from disk: assets/index.css
2024-03-28T15:02:08.476Z: Reading theme file: assets/index.css
2024-03-28T15:02:08.481Z: Reading the content of file at assets/index.css...
2024-03-28T15:02:08.481Z: All theme files were read from disk
2024-03-28T15:02:08.482Z: Getting the size of file file at assets/index.css...
2024-03-28T15:02:08.518Z: Uploading the following files:
-assets/index.css
2024-03-28T15:02:08.603Z: Request to https://theme-kit-access.shopifyapps.com/cli/admin/api/unstable/themes/159602639172/assets/bulk.json completed in 83 ms
With response headers:
- content-type: text/html; charset=UTF-8
- x-request-id: 5be093b9-f16d-4bda-9bd1-695cb90e9b0f-1711638128
2024-03-28T15:02:08.604Z: File Upload Results:
╭─ success ────────────────────────────────────────────────────────────────────╮
│ │
│ The theme 'webdev-Shopify/stage' (#159602639172) was pushed │
│ successfully. │
│ │
│ Next steps │
│ • View your theme [1] │
│ • Customize your theme at the theme editor [2] │
│ │
╰──────────────────────────────────────────────────────────────────────────────╯
[1] https://***
[2] https://***/admin/themes/159602639172/editor
2024-03-28T15:02:08.641Z: Obtaining the dependency manager in directory /home/runner/work/webdev-Shopify-ESN/webdev-Shopify-ESN...
2024-03-28T15:02:08.653Z:
Running system process:
· Command: ruby -v
· Working directory: /home/runner/work/webdev-Shopify-ESN/webdev-Shopify-ESN
2024-03-28T15:02:08.805Z: Request to https://monorail-edge.shopifysvc.com/v1/produce completed in 125 ms
With response headers:
- x-request-id: a16b7f62-abde-4601-afd8-3f407df1bad7
2024-03-28T15:02:08.806Z: Analytics event sent: {
"command": "theme push",
"time_start": 1711638125397,
"time_end": 1711638128638,
"total_time": 3241,
"success": true,
"cli_version": "3.58.0",
"ruby_version": "3.1.4",
"node_version": "20.11.1",
"is_employee": false,
"uname": "linux amd64",
"env_ci": true,
"env_ci_platform": "github",
"env_plugin_installed_any_custom": false,
"env_plugin_installed_shopify": "[\"@shopify/cli\",\"@shopify/plugin-did-you-mean\",\"@shopify/theme\"]",
"env_shell": "bash",
"env_device_id": "0ceaa8fdcfb5b05a0a33f0c82be5438552dd0891",
"env_cloud": "localhost",
"env_package_manager": "yarn",
"cmd_all_timing_network_ms": 2105,
"cmd_all_timing_prompts_ms": 0,
"cmd_all_launcher": "unknown",
"cmd_all_topic": "theme",
"cmd_all_plugin": "@shopify/theme",
"cmd_all_force": false,
"cmd_all_verbose": true,
"cmd_all_path_override": true,
"cmd_all_path_override_hash": "ad38e66e142cf8bbeabdc65e0652654674422f54",
"cmd_all_timing_active_ms": 1135,
"cmd_all_exit": "ok",
"args": "-o assets/components-legacy.bundle.js -o assets/components.bundle.js -o assets/checkout-legacy.bundle.js -o assets/checkout.bundle.js -o assets/index.css -l -a --verbose",
"env_plugin_installed_all": "[\"@shopify/cli\",\"@shopify/plugin-did-you-mean\",\"@shopify/theme\"]",
"metadata": "{\"extraPublic\":{},\"extraSensitive\":{}}"
}
2024-03-28T15:02:08.806Z: Completed command theme push
### Reproduction steps
1. Install 3.58.0 in a github action
2. use the theme push command
3.
### Operating System
Github Action
### Shopify CLI version (check your project's `package.json` if you're not sure)
3.58.0
### Shell
_No response_
### Node version (run `node -v` if you're not sure)
v20
### What language and version are you using in your application?
_No response_
it was working fine yesterday.About this issue
- Original URL
- State: closed
- Created 3 months ago
- Reactions: 3
- Comments: 15 (2 by maintainers)
Same. If anyone at Shopify is reading, can you PLEASE get a grip of your software testing/release practices - I’m not exaggerating when I say that the last 3 releases you’ve made have fundamentally broken core functionality - How does a release of a CLI tool get published that doesn’t upload files?!
The fact that there’s a “–stable” flag to keep it working as it always has is indicative of the problem: If you’re going to fundamentally change something then do what everyone else does and create a new major version to make it obvious that it’s a breaking change and allow people to test and upgrade in a controlled fashion.
Many of the customers using this tool aren’t single store individuals running a side hustle - It’s large enterprises that are running multiple stores supported by development teams pushing multiple changes a day via CI pipelines. I got called out on a bank holiday because our entire 15 person development team couldn’t push code.
I used --stable flag and it worked. Looks like it did not read password and store name flags without it. It’s really annoying to solve another mystery for every version of CLI. Pipeline logs success and suddenly changes ideas to not push any files.
Having the same issue but on bitbucket pipelines.
It is working as expected again in 3.58.2
Hey @p-ludewig-ext-tqgg, This should be fixed in
https://github.com/Shopify/cli/releases/tag/3.58.2Could you try upgrading and let me know if that works? Otherwise, please use the
--stableflag and let us know so we can look further into a fixSame issue with theme push broken in 3.58.0, except I’m not using any automation.
theme pushitself was broken, and the behavior changed from what was previously in place.Instead of a list presented to select the theme to push to, we are now met with a dialog asking which theme to open… yes you read that correctly, open, not push.
Looks like this PR was merged last week and released in 3.58.0, moving theme push from Ruby implementation and sticking the previous, working Ruby implementation behind a temporary --stable flag.
This PR should really be rolled back.