oplayer: Entering into fullscreen mode on iPhone is broken

This is the error from the Web Inspector console: [Error] TypeError: undefined is not an object (evaluating ‘o(this, T, U).call’) enterFullscreen (chunk-KSDSIAZN.js:390) toggleFullScreen (chunk-KSDSIAZN.js:399)

  enterFullscreen() {
    this.#requestFullscreen.call(this.$root, { navigationUI: 'hide' }) // <-- this line seems to throw the error
    this.emit('fullscreenchange')
  }

https://github.com/shiyiya/oplayer/blob/f0bf039b429f634f98541269c4734322ea855985/packages/core/src/player.ts#L237

The tooltip that pops-up after the click, brings the video into semi-fullscreen that only expands into the browser window, not the true full screen. I think that it is due to the playsinline setting. I know that VideoJS is working well, but I think that they remove the playes inline prop from the video attribute when the user clicks the full screen switch. And they put it back, when the screen is returned to normal.

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 28 (28 by maintainers)

Commits related to this issue

Most upvoted comments

If you change the progress bar before clicking the play button and then click play, it will behave in many strange ways