build: Automatically trigger the first BuildRun
Why?
- Improve the experience for running the first build execution.
How?
- On creation of a
Build, automatically trigger the creation of aBuildRun. - Use an annotation to disable this behaviour.
- ~Have the controller add/update an annotation to record the creation of a
BuildRun.~
About this issue
- Original URL
- State: open
- Created 4 years ago
- Reactions: 1
- Comments: 17 (17 by maintainers)
@otaviof hi, for:
If the creation of the
BuildRunhappens in theBuildreconciler, I think it should be manage as yet another validation in theBuildreconciliation. If a validation fails in the Build, we reconcile again and again and again … 😃Sounds good, @otaviof .
How would the controller, in subsequent reconciliations understand that the first build has already been triggered? Would that be by looking at
statusinformation?Same annotation.
If I create a Build with no annotation, then the controller creates the first BuildRun, and sets an annotation pending=false ( default behaviour )
If I create a Build with an annotation pending=false, then do nothing.
If I create a Build with an annotation pending=true, do same as (1)
What do you think?