zf1-future: Broken Zend_Db_Table_Rowset::current function
Hello,
First of all: thank’s a lot to maintain ZF-1. Great work! 😃
Am I wrong? I think the return type of Zend_Db_Table_Rowset::current function recently added mixed is wrong. The function return Zend_Db_Table_Row_Abstract or null. mixed is union of string|int|float|bool|null|array|object|callable|resource. So Php complain when the function return Zend_Db_Table_Row_Abstract.
Here’s the hash of the commit: ad81d0c2c6b5ee9207627022197b3a952418256b
Malo
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 18 (9 by maintainers)
Commits related to this issue
- Added some mixed return types recently — committed to Shardj/zf1-future by Shardj 2 years ago
You can just put a #[\ReturnTypeWillChange] attribute to mask the deprecation till Php 9.0, and prevent any potential BC breaks.
Actually @hc-jworman do you want to just add those attributes to your PR https://github.com/Shardj/zf1-future/pull/196 and I’ll merge it. Thanks for being so proactive with this issue
Yeah it’s fine, I’ll just go delete it
Would removing version 1.20.1 help?
Okay, go nuts: release-1.20.2
Will be fixed in https://github.com/Shardj/zf1-future/pull/196