web: DeFI - View position not available after staking
Overview
After staking in some vault and clicking “View Position”, DeFI overview doesn’t show the position.
Steps to reproduce:
- Stake some asset in DeFi vault
- Wait for Metamask confirmation
- On the last step of the modal, click “View Position”
Expected:
- No full page reload is necessary for my position to appear
- I can view my position, it is available as a card
Actual:
- My position is not there
- A full page reload is necessary for it to appear
References and additional details
- https://github.com/shapeshift/web/commit/34a17854cda6a37b2dc1568f72e30b428eafd9f5 fixed most things regarded to the app updating on new Txs
useEarnBalancesselectPortfolioTotalFiatBalanceWithDelegations<AllEarnOpportunities />
Acceptance Criteria
As a user, my new/updated staking position should appear:
- Overview card is updated to reflect the new/updated position
- Earn row is updated to reflect the new/updated position
- The deposit modal is updated, so that the amount is deducted from the amount available to deposit, and added to the amount available to unstake
- Account balance is updated to reflect the new/updated position
Need By Date
No response
Screenshots/Mockups
No response
Ownership
- If my bounty needs engineering or needs product I have added the respective labels on the right
- As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)
Estimated effort
No response
Sponsor / Stakeholder
@gomesalexandre (gomes on Discord)
Bounty Hunters
- Join our discord
- Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
- Please refer to this link for some basic info
- Please do not start work on this issue until you are approved in Gitcoin.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 16 (10 by maintainers)
Commits related to this issue
- feat(caip): remove getFeeAssetIdFromAssetId / chainIdToAssetId (#908) * feat(caip): remove getFeeAssetIdFromAssetId / chainIdToAssetId * chore(caip): import chainId caip exports relatively * ch... — committed to shapeshift/web by gomesalexandre 2 years ago
- chore(release): 6.8.0 [skip ci] # [@shapeshiftoss/caip-v6.8.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/caip-v6.7.1...@shapeshiftoss/caip-v6.8.0) (2022-08-01) ### Features * **caip:... — committed to shapeshift/web by semantic-release-bot 2 years ago
- chore(release): 9.3.0 [skip ci] # [@shapeshiftoss/swapper-v9.3.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v9.2.3...@shapeshiftoss/swapper-v9.3.0) (2022-08-01) ### Features ... — committed to shapeshift/web by semantic-release-bot 2 years ago
Card did not update automatically once selecting “view position”. Had to do a refresh to see the updated balance,
@0xdef1cafe saw 2116 is merged. position is there without doing a full reload. LGTM
Hey @gomesalexandre! sorry for the delay on this. But was able to stake (tried WETH in my case) ,clicked on 'View Position" but the card didn’t appear on the Overview page. Had to refresh the page for it to show up.
root cause is here https://github.com/shapeshift/web/issues/706