shaka-player: Wrong role and language after DAI in v3.0+

Hi Shaka Team, We are seeing a regression in 3.0.2 when comparing to 2.5.14 around multi audio detection when there are duplicate lang string, one set with a role, the other no role.

Basically, MPD has two audio tracks both with lang=“en”, but one has the role attribute for descriptive audio. once parsed by shaka, we only see one english track, the one with the role attribute and the normal english audio track is dropped.

Regular English Audio Track, no Role. (track dropped in 3.0.2 but available as expected in 2.5.14.)

<AdaptationSet id="5" contentType="audio" lang="en" segmentAlignment="true">
      <Representation id="5" bandwidth="126477" codecs="mp4a.40.2" mimeType="audio/mp4" audioSamplingRate="48000">
        <SegmentTemplate timescale="48000" initialization="init.m4v" media="seg_$Number$.m4s" startNumber="1">

Descriptive English Audio Track with Role.

<AdaptationSet id=“5” contentType=“audio” lang=“en” segmentAlignment=“true”>
   <Accessibility schemeIdUri=“urn:tva:metadata:cs:AudioPurposeCS:2007” value=“1"/>
   <Role schemeIdUri=“urn:mpeg:dash:role:2011” value=“description”/>
   <Representation id=“5” bandwidth=“127871" codecs=“mp4a.40.2” mimeType=“audio/mp4" audioSamplingRate=“48000”>
    <AudioChannelConfiguration schemeIdUri=“urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value=“2”/>
    <SegmentTemplate timescale=“48000" presentationTimeOffset=“118966848” initialization=“init.m4v” media=“seg_$Number$.m4s” startNumber=“417">

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? 3.0.2

Can you reproduce the issue with our latest release version? Yes

Can you reproduce the issue with the latest code from master? Have not had time to try yet, but will

If custom app, can you reproduce the issue using our demo app? Both

What browser and OS are you using? Chrome

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 23 (23 by maintainers)

Commits related to this issue

fix(period flattening): Combine text streams with no roles If two text streams in two periods have no roles while other text streams have, combine those with no roles. Issue #2785 b/172605645 Chang... — committed to shaka-project/shaka-player by michellezhuogg 4 years ago
fix(period flattening): Combine the streams with no roles If two audio streams in two periods have no roles while other audio streams have, combine those with no roles. Fixes #2785 b/172605645 Chan... — committed to shaka-project/shaka-player by michellezhuogg 4 years ago
fix(period flattening): Combine text streams with no roles If two text streams in two periods have no roles while other text streams have, combine those with no roles. Issue #2785 b/172605645 Chang... — committed to shaka-project/shaka-player by michellezhuogg 4 years ago

Most upvoted comments

@joeyparrish Not showing any issue with the media I sent on my side as well. I am sorry for the false alarm. I am looking at notes to find what media did show this (if any) and if that media is valid regarding audio and roles etc.

We had some test media but hoping that did not mix in and mislead me to file this.

For today, can we leave this open? I’ll do more testing then come back and close it tomorrow?

I also noticed that the Endianness change for IE and Edge made it into 3.0.4. So we will look at bailing on our Fork of 2.10.14 and getting on 3.0.4 as well.

Thanks for the effort. I think the xbox decode issue is our last one. We have moved shaka to be default provider in our player as of this release!

dsparacio on Sep 9, 2020