shaka-player: Memory leak on multi-period streams
Have you read the FAQ and checked for duplicate open issues? Yes
If the problem is related to FairPlay, have you read the tutorial?
Yes
What version of Shaka Player are you using?
4.2.x => 4.7.x
Can you reproduce the issue with our latest release version? Yes
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app? Demo app
If custom app, can you reproduce the issue using our demo app? Yes
What browser and OS are you using? chrome, windows
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
What configuration are you using? What is the output of player.getConfiguration()?
Default
What did you do?
Play stream and take memory heap snapshots using chrome dev tools at different times
What did you expect to happen? Memory heap to be stable
What actually happened?
Memory heap grows consistently for multi-period streams. On mono-period streams, we dot not notice the same result.
Please find screenshots:
-
Heap snapshots to illustrate inscrease of memory consumption:
-
Snapshots comparison after 45 minutes
-
Details and allocation call stack (based on v4.5.x) of retained objects
Please note that all objects (Text, Element, NodeList …) are allocated in the same place.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 23 (12 by maintainers)
Commits related to this issue
- fix(DASH): Clear streamMap when period is removed from the manifest (#7202) Related to https://github.com/shaka-project/shaka-player/issues/6239 and https://github.com/shaka-project/shaka-player/iss... — committed to shaka-project/shaka-player by Iragne 2 years ago
- fix(DASH): Clear streamMap when period is removed from the manifest (#7202) Related to https://github.com/shaka-project/shaka-player/issues/6239 and https://github.com/shaka-project/shaka-player/issu... — committed to shaka-project/shaka-player by Iragne 2 years ago
- fix(DASH): Clear streamMap when period is removed from the manifest (#7202) Related to https://github.com/shaka-project/shaka-player/issues/6239 and https://github.com/shaka-project/shaka-player/iss... — committed to shaka-project/shaka-player by Iragne 2 years ago
- fix(DASH): Evict empty indexes in MetaSegmentIndex Issue #6239 — committed to theodab/shaka-player by theodab 2 years ago
- fix(DASH): Avoid adding originalId when it is not necessary (#7281) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- fix(DASH): Evict empty indexes in MetaSegmentIndex (#7272) Issue #6239 --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com> — committed to shaka-project/shaka-player by theodab 2 years ago
- fix(DASH): Avoid adding originalId when it is not necessary (#7281) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- fix(DASH): Evict empty indexes in MetaSegmentIndex (#7272) Issue #6239 --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com> — committed to shaka-project/shaka-player by theodab 2 years ago
- fix(DASH): Avoid adding originalId when it is not necessary (#7281) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- fix(DASH): Evict empty indexes in MetaSegmentIndex (#7272) Issue #6239 --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com> — committed to shaka-project/shaka-player by theodab 2 years ago
- fix(DASH): Evict (by time) indexes in MetaSegmentIndex (#7296) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- perf(DASH): Delete old matchedStreams (#7301) Issue: https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- perf: Only use tXml parent when necessary (#7304) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- fix(DASH): Clear usedPeriodIds when period is removed from the manifest (#7305) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- fix(DASH): Evict (by time) indexes in MetaSegmentIndex (#7296) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- perf(DASH): Delete old matchedStreams (#7301) Issue: https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- perf: Only use tXml parent when necessary (#7304) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- fix(DASH): Clear usedPeriodIds when period is removed from the manifest (#7305) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- fix(DASH): Evict (by time) indexes in MetaSegmentIndex (#7296) Issue https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
- perf(DASH): Delete old matchedStreams (#7301) Issue: https://github.com/shaka-project/shaka-player/issues/6239 — committed to shaka-project/shaka-player by avelad 2 years ago
thanks for the update @bbert! Since we have already improved everything we could, I proceed to close the issue as resolved!
we should reopen this.