fastnumbers: [regression] error: unknown type name 'PyObject'

While trying to update the FreeBSD port to 2.1.0 this new error occurs:

In file included from /usr/ports/devel/py-fastnumbers/work-py27/fastnumbers-2.1.0/include/strings.h:9:
/usr/ports/devel/py-fastnumbers/work-py27/fastnumbers-2.1.0/include/options.h:15:5: error: unknown type name 'PyObject'
    PyObject *retval;
    ^
/usr/ports/devel/py-fastnumbers/work-py27/fastnumbers-2.1.0/include/options.h:16:5: error: unknown type name 'PyObject'
    PyObject *input;
    ^
/usr/ports/devel/py-fastnumbers/work-py27/fastnumbers-2.1.0/include/options.h:17:5: error: unknown type name 'PyObject'
    PyObject *key;
    ^

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 22 (13 by maintainers)

Commits related to this issue

Move all headers to include/fastnumbers. This forces all includes to use #include "fastnumbers/strings.h", which significantly reduces the chance of name conflicts. On the FreeBSD port, there was a ... — committed to SethMMorton/fastnumbers by SethMMorton 6 years ago

Most upvoted comments

Thank you, that was very helpful. It seems that somehow the file header file “strings.h” is conflicting with the system include file “strings.h” when “Python.h” is included. I imagine that the system “string.h” includes “strings.h” on line 45.

I find it interesting that this did not occur on any other system I compiled on.

I will create a PR and ask you to validate that the port is successful once that has been completed.

SethMMorton on Aug 19, 2018