servo: Throw NotSupported error instead of Type in XRSession::UpdateRenderState
Code: https://github.com/servo/servo/blob/ffccc5c88b8d47efc777b0bc9d2620bed4bc84d7/components/script/dom/xrsession.rs#L619-L622 Specification: Step 1 of https://immersive-web.github.io/layers/#updaterenderstatechanges Test: https://github.com/servo/servo/blob/main/tests/wpt/tests/webxr/layers/xrSession_updateRenderState.https.html Expected results: https://github.com/servo/servo/blob/main/tests/wpt/meta/webxr/layers/xrSession_updateRenderState.https.html.ini
After changing the code, run ./mach test-wpt tests/wpt/tests/webxr/layers/xrSession_updateRenderState.https.html to verify that the test now passes, then update the expected results.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 22 (22 by maintainers)
Can you show the output of
git diff? Have you tried adding a println! to the code you’re changing to verify that it’s executing when you run the test?Aha! Yes, that is correct. Yeah, the tests run the servo binary from the target directory, and the binary is made by compiling the source files.
@jdm this is what i am supposed to get right? I think i might have finally figured out what i was doing wrong,
while i was working on CanGc I recieved this error:
and realised i need to ./mach build AFTER i make the NotSupport change, since i guess the test runs the target build files? I thought it just ran the file i directly changed.
I recommend deleting your target directory before building again.
When I make the same change from https://github.com/servo/servo/issues/33714#issuecomment-2402218129 I get:
This makes me strongly suspect that you are somehow not running the binary that contains the changes you have made to the source code.
I recommend adding log lines to the test file to determine which subtest is failing right now, and then figuring out if we can address that failure in our implementation!