servo: Throw NotSupported error instead of Type in XRSession::UpdateRenderState

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 22 (22 by maintainers)

Most upvoted comments

Can you show the output of git diff? Have you tried adding a println! to the code you’re changing to verify that it’s executing when you run the test?

Aha! Yes, that is correct. Yeah, the tests run the servo binary from the target directory, and the binary is made by compiling the source files.

@jdm this is what i am supposed to get right? I think i might have finally figured out what i was doing wrong, image

while i was working on CanGc I recieved this error:

method `Slice` has 5 parameters but the declaration in trait `dom::bindings::codegen::Bindings::BlobBinding::Blob_Binding::BlobMethods::Slice` has 4

and realised i need to ./mach build AFTER i make the NotSupport change, since i guess the test runs the target build files? I thought it just ran the file i directly changed.

I recommend deleting your target directory before building again.

When I make the same change from https://github.com/servo/servo/issues/33714#issuecomment-2402218129 I get:

Unexpected Results
------------------
/webxr/layers/xrSession_updateRenderState.https.html
  UNEXPECTED-PASS Ensure XRSession throws appropriate errors when updating render state with layers feature enabled - webgl
  UNEXPECTED-PASS Ensure XRSession throws appropriate errors when updating render state with layers feature enabled - webgl2

This makes me strongly suspect that you are somehow not running the binary that contains the changes you have made to the source code.

I recommend adding log lines to the test file to determine which subtest is failing right now, and then figuring out if we can address that failure in our implementation!