I haven’t read the whole discussion in this issue but this shouldn’t be a breaking change beyond bumping the minimum supported rustc version from 1.13 to 1.26. Rather than exposing a Cargo cfg I would prefer to automatically detect when we are on a sufficiently new compiler and provide the impls without a cfg opt-in.
@dtolnay Since u128/i128 is a stable and elementary datatype, I’d argue that it makes more sense to think of this as a bug rather than an enhancement. A newcomer to Rust/Serde doesn’t know the history of 128 bit types and would consider it broken if Serde worked fine with one size of basic integer but not another.
I published 1.0.60 with this feature.
I haven’t read the whole discussion in this issue but this shouldn’t be a breaking change beyond bumping the minimum supported rustc version from 1.13 to 1.26. Rather than exposing a Cargo cfg I would prefer to automatically detect when we are on a sufficiently new compiler and provide the impls without a cfg opt-in.
@dtolnay Since
u128/i128is a stable and elementary datatype, I’d argue that it makes more sense to think of this as a bug rather than an enhancement. A newcomer to Rust/Serde doesn’t know the history of 128 bit types and would consider it broken if Serde worked fine with one size of basic integer but not another.We can’t add them directly, because that would break all users of older rustc stable versions
We could add it under a (stable) feature flag